Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reporter #36

Merged
merged 2 commits into from
Aug 29, 2021
Merged

feat: add reporter #36

merged 2 commits into from
Aug 29, 2021

Conversation

arjenzhou
Copy link
Owner

@arjenzhou arjenzhou commented Aug 29, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a ISSUE field for the change (usually
    before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should
    address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample in project.
  • Add some description to documents if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.

@arjenzhou arjenzhou changed the title feat: 增加 reporter feat: add reporter Aug 29, 2021
@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #36 (a1000f6) into master (9eda588) will increase coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
+ Coverage     58.66%   59.30%   +0.64%     
- Complexity      159      162       +3     
============================================
  Files            37       38       +1     
  Lines           912      919       +7     
  Branches         62       61       -1     
============================================
+ Hits            535      545      +10     
+ Misses          334      332       -2     
+ Partials         43       42       -1     
Impacted Files Coverage Δ
...de/xab/porter/transfer/channel/DefaultChannel.java 73.33% <ø> (+8.62%) ⬆️
core/src/main/java/de/xab/porter/core/Session.java 100.00% <100.00%> (ø)
core/src/main/java/de/xab/porter/core/Task.java 89.36% <100.00%> (+1.26%) ⬆️
...de/xab/porter/transfer/jdbc/reader/JDBCReader.java 63.41% <100.00%> (+0.51%) ⬆️
.../xab/porter/transfer/reporter/DefaultReporter.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eda588...a1000f6. Read the comment docs.

@arjenzhou arjenzhou merged commit dea86b7 into master Aug 29, 2021
@arjenzhou arjenzhou deleted the feat-web branch October 18, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant