Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: delegate connect action to Connector #35

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

arjenzhou
Copy link
Owner

What is the purpose of the change

#34

Brief changelog

Verifying this change

Checklist

  • Make sure there is a ISSUE field for the change (usually
    before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should
    address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample in project.
  • Add some description to documents if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #35 (65bd538) into master (365f73b) will increase coverage by 0.75%.
The diff coverage is 69.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
+ Coverage     57.90%   58.66%   +0.75%     
- Complexity      154      159       +5     
============================================
  Files            35       37       +2     
  Lines           879      912      +33     
  Branches         58       62       +4     
============================================
+ Hits            509      535      +26     
- Misses          329      334       +5     
- Partials         41       43       +2     
Impacted Files Coverage Δ
.../porter/transfer/jdbc/connector/JDBCConnector.java 0.00% <ø> (-68.19%) ⬇️
.../porter/transfer/jdbc/writer/PostgreSQLWriter.java 0.00% <0.00%> (ø)
.../de/xab/porter/transfer/connector/Connectable.java 0.00% <ø> (ø)
...va/de/xab/porter/transfer/connector/Connector.java 0.00% <0.00%> (ø)
...java/de/xab/porter/common/spi/ExtensionLoader.java 74.75% <60.71%> (+6.27%) ⬆️
.../xab/porter/api/dataconnection/DataConnection.java 62.26% <66.66%> (+0.56%) ⬆️
.../de/xab/porter/transfer/reader/AbstractReader.java 71.42% <69.23%> (-3.58%) ⬇️
...orter/transfer/jdbc/connector/HikariConnector.java 72.72% <72.72%> (ø)
...de/xab/porter/transfer/jdbc/writer/JDBCWriter.java 50.34% <77.77%> (-1.01%) ⬇️
...de/xab/porter/transfer/jdbc/reader/JDBCReader.java 62.90% <81.81%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365f73b...65bd538. Read the comment docs.

@arjenzhou arjenzhou merged commit 9eda588 into master Aug 21, 2021
@arjenzhou arjenzhou deleted the feat-connector-proxy branch August 21, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant