Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache SPI extension classes #27

Merged
merged 1 commit into from
Jul 25, 2021
Merged

chore: cache SPI extension classes #27

merged 1 commit into from
Jul 25, 2021

Conversation

arjenzhou
Copy link
Owner

What is the purpose of the change

cache SPI extension classes

Brief changelog

add extension classes cache in SPI

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually
    before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should
    address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample in project.
  • Add some description to documents if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #27 (0c64409) into master (199c15c) will decrease coverage by 0.43%.
The diff coverage is 67.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #27      +/-   ##
============================================
- Coverage     59.57%   59.13%   -0.44%     
- Complexity      146      150       +4     
============================================
  Files            33       34       +1     
  Lines           841      859      +18     
  Branches         55       58       +3     
============================================
+ Hits            501      508       +7     
- Misses          299      308       +9     
- Partials         41       43       +2     
Impacted Files Coverage Δ
...c/main/java/de/xab/porter/common/util/Strings.java 100.00% <ø> (ø)
...de/xab/porter/transfer/jdbc/reader/JDBCReader.java 61.20% <0.00%> (ø)
...de/xab/porter/transfer/jdbc/writer/JDBCWriter.java 51.77% <0.00%> (ø)
.../porter/transfer/jdbc/writer/PostgreSQLWriter.java 0.00% <0.00%> (ø)
...porter/transfer/exception/ConnectionException.java 0.00% <0.00%> (ø)
...java/de/xab/porter/common/spi/ExtensionLoader.java 75.78% <76.56%> (+5.67%) ⬆️
core/src/main/java/de/xab/porter/core/Task.java 94.73% <100.00%> (ø)
...a/de/xab/porter/api/exception/PorterException.java 0.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199c15c...0c64409. Read the comment docs.

@arjenzhou arjenzhou merged commit f9ab562 into master Jul 25, 2021
@arjenzhou arjenzhou deleted the extensionloader branch July 25, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant