Upgrade to Qt 4.8.4

[jonleighton]

I have tested on Linux and verified that it compiles, the phantomjs tests pass, and the poltergeist tests also pass.

This commit comes from applying the diff between 4.8.2 and 4.8.4 on top of phantomjs' source. There were some merge conflicts which I worked through by hand (mainly bug fixes that we had already backported).

[JamesMGreene]

Well... that looks like a fun changeset to review. Enjoy, @ariya! 😛

[jonleighton]

It's mostly changes in the license headers to replace mentions of Nokia with Digia.

[JamesMGreene]

Compiling for Windows now... I'll let you know what I find in a few hours. Sadly, the Windows binaries usually have a number of tests failing or hanging anyway (most due to slow web requests/DNS binding).

[detro]

Testing build on mac

[djgoku]

I was able to build on Mountain Lion.

After running test/run-tests.js:

#130 Text codec support: Should support text codec Shift_JIS
FAIL
#131 Text codec support: Should support text codec EUC-JP
FAIL
#132 Text codec support: Should support text codec ISO-2022-JP
FAIL
#133 Text codec support: Should support text codec Big5
FAIL
#134 Text codec support: Should support text codec GBK
FAIL

Finished in 5.694 seconds

262 specs, 5 failures

[ariya]

OS X and codec failures are known, not a regression.

[JamesMGreene]

My first test run on Windows had ~30 more failures than usual (~40 failures), mostly in the Frames API. However, it was hopefully just a fluke as every subsequent test run has been back to my normal range (~10 failures).

Started

�[31m#175 WebServer object: should fail to listen to blocked ports�[0m
�[31mFAIL�[0m

�[31m#177 WebServer object: should handle requests�[0m
�[31mFAIL�[0m

�[31m#178 WebServer object: should handle post requests ('Content-Type' = 'application/x-www-form-urlencoded')�[0m
�[31mFAIL�[0m

�[31m#179 WebServer object: should handle post requests ('Content-Type' = 'ANY')�[0m
�[31mFAIL�[0m

�[31m#201 Files and Directories API: should create a file in the Current Working Directory and check it's absolute path�[0m
�[31mFAIL�[0m

�[31m#203 Files and Directories API: should copy Content of the '/test/' Directory in a temporary directory, compare with the original and then remove�[0m
�[31mFAIL�[0m

�[31m262 specs, 9 failures�[0m

I don't believe any of these failures are new.

Interestingly, it reports 9 failures yet only shows 6... so either it sucks at counting, it's counting assertions rather than tests, or something can occur that prevents tests from reporting (e.g. unhandled error?).

[detro]

• Built fine on Mac OSX "Mountain Lion"
• All PhantomJS tests pass (less the know 4/5 issues with encoding)
• All GhostDriver tests pass

I think we got a very nice green light 👍

[ariya]

Landed. Thank you very much!