-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Use VRF ID instead of VRF VNI as offset for evpn underlay l3 multicast group #4450
Refactor(eos_designs): Use VRF ID instead of VRF VNI as offset for evpn underlay l3 multicast group #4450
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4450
# Activate the virtual environment
source test-avd-pr-4450/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@TODO_vrf_id#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,TODO_vrf_id --force
# Optional: Install AVD examples
cd test-avd-pr-4450
ansible-playbook arista.avd.install_examples |
18696d0
to
bafda8e
Compare
Needed to update the description of key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
python-avd/pyavd/_eos_designs/structured_config/network_services/vxlan_interface.py
Show resolved
Hide resolved
6d8d505
to
255bfd2
Compare
3f91b6e
to
dba751b
Compare
0905e71
to
af2726b
Compare
…pn underlay l3 multicast group exit
Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
af2726b
to
5294cca
Compare
Quality Gate passedIssues Measures |
several changes since this review
Change Summary
Change algorithm to use VRF ID instead of VRF VNI as offset. (in evpn_underlay_l3_multicast_group())
Related Issue(s)
Fixes #https://github.com/aristanetworks/avd-internal/issues/161
Component(s) name
arista.avd.eos_designs
Proposed changes
replaced vrf_vni with vrf_id in evpn_underlay_l3_multicast_group()
Checklist
Repository Checklist