Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Use VRF ID instead of VRF VNI as offset for evpn underlay l3 multicast group #4450

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Sep 10, 2024

Change Summary

Change algorithm to use VRF ID instead of VRF VNI as offset. (in evpn_underlay_l3_multicast_group())

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/161

Component(s) name

arista.avd.eos_designs

Proposed changes

replaced vrf_vni with vrf_id in evpn_underlay_l3_multicast_group()

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Sep 10, 2024
@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR labels Sep 10, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4450
# Activate the virtual environment
source test-avd-pr-4450/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@TODO_vrf_id#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,TODO_vrf_id --force
# Optional: Install AVD examples
cd test-avd-pr-4450
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review September 11, 2024 12:06
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners September 11, 2024 12:06
@Vibhu-gslab Vibhu-gslab marked this pull request as draft September 11, 2024 12:06
@Vibhu-gslab Vibhu-gslab added this to the v5.0.0 milestone Sep 11, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 11, 2024 12:08
@laxmikantchintakindi
Copy link
Contributor

Needed to update the description of key evpn_l3_multicast in defs_network_services_schema.

Shivani-gslab
Shivani-gslab previously approved these changes Sep 11, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laxmikantchintakindi
Copy link
Contributor

LGTM

@Vibhu-gslab Vibhu-gslab marked this pull request as draft September 12, 2024 11:25
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review September 13, 2024 04:37
@Vibhu-gslab Vibhu-gslab marked this pull request as draft September 13, 2024 07:53
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review September 13, 2024 11:12
@Vibhu-gslab Vibhu-gslab force-pushed the TODO_vrf_id branch 3 times, most recently from 0905e71 to af2726b Compare September 17, 2024 04:50
Copy link

sonarcloud bot commented Sep 18, 2024

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review September 18, 2024 05:46
@ClausHolbechArista ClausHolbechArista dismissed stale reviews from laxmikantchintakindi and Shivani-gslab September 18, 2024 07:31

several changes since this review

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 18, 2024
@ClausHolbechArista ClausHolbechArista merged commit 97fe7b1 into aristanetworks:devel Sep 18, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants