Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] A way of dealing with furigana in subtitles. #30

Closed
Feripe-a opened this issue Jul 11, 2021 · 4 comments
Closed

[Feature Request] A way of dealing with furigana in subtitles. #30

Feripe-a opened this issue Jul 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Feripe-a
Copy link

Feripe-a commented Jul 11, 2021

I've found a problem with subs that have furigana, mainly those you find on Netflix subs.
Screenshot_2021-07-11-20-15-59-816_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-16-37-395_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-22-36-690_com lrorpilla jidoujisho
Screenshot_2021-07-11-20-22-44-318_com lrorpilla jidoujisho
The word can't be parsed at all because there's furigana on almost every kanji. My request is:

  • Skip furigana when parsing;
  • Option to turn furigana on and off (because it might be helpful for some users);
  • Automatically remove furigana when a cards is created.

You can find the subtitle in the screenshots here. But it's pretty common to have furigana in subs — I personally find them annoying.
I'm not aware of other patterns to indicate furigana, so far I've only encountered the one present in the screenshots. There might be more patterns.

@arianneorpilla
Copy link
Owner

Seems to be exactly related to this Yomichan issue and I will have to offer a similar solution.

@arianneorpilla
Copy link
Owner

arianneorpilla commented Jul 12, 2021

I am on hiatus but this is pretty easy to offer a band-aid solution to this with a regular expression filter so I've gone ahead and implemented it in 0.25.5.

You will need to apply the following filter if you want to hide anything within parentheses as per the linked Yomichan solution: [(]([^)]*)[)]and be sure to set and remember if you want to keep the filter across all following videos.

I believe this is a broad solution that can be adaptable to different ways Furigana can be represented and you will have to be proficient in regular expressions should you find a format that doesn't quite fit the Netflix subtitles pattern but the filter above should function well enough for your purposes.

I should mention I will be on hiatus for a short while, so if there are any newer issues I won't be able to address them as soon as I have, I should be reading but I figure this one change is pretty fast enough to make.

If there are any additional issues, feel free to re-open.

@arianneorpilla
Copy link
Owner

I've reuploaded that release so that the filter should also work on subtitles upon export.

@Feripe-a
Copy link
Author

I should mention I will be on hiatus for a short while

No problem. Go and immerse yourself. I've doing a great job lately. We really appreciate the time you've spent developing this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants