fix: speed up sqrt and inversion for FP, FP2, using unconstrained #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwared
force-pushed
the
unconstrained_zkvm_invert
branch
from
22045d0 to
061e266
Compare
huitseeker
force-pushed
the
unconstrained_zkvm_invert
branch
22 times, most recently
from
313ebb3 to
c5e40f9
Compare
- Added new optional 'sphinx-zkvm' dependency and 'zkvm' feature in Cargo.toml - Modified `sqrt` method in `Fp2` file, adding differentiated execution logic based on the `target_os` - Adjusted `Fp2` operations to handle quadratic nonresidue during the square root computation effectively and to conform to environment specifications.
- Modified the `Cargo.toml` file to restrict `sphinx-zkvm` dependency to a `zkvm` target OS context, mitigating potential circular dependency issues - Removed `zkvm` from the feature flags in the `Cargo.toml` file - Introduced a `sqrt_impl` macro in `src/fp2.rs` to refactor the square root calculations in `sqrt` method - Did the same with a inv_impl for the inverse
huitseeker
force-pushed
the
unconstrained_zkvm_invert
branch
from
2d4992b to
d162718
Compare
wwared
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqrtmethod inFp2file, adding differentiated execution logic based on thetarget_osFp2operations to handle quadratic nonresidue during the square root computation effectively and to conform to environment specifications.This is just a thought experiment: it seems we're not actively using either.