feat: Add support for HPA v2 (autoscaling/v2) #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Monbillard <f.monbillard@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 54.52% 54.66% +0.14%
==========================================
Files 41 41
Lines 3059 3073 +14
==========================================
+ Hits 1668 1680 +12
- Misses 1228 1229 +1
- Partials 163 164 +1
Continue to review full report at Codecov.
|
|
Hi, do we have any updates on this one? can be this merged already? |
|
please some one approve this MR, this is important for us :) |
alexmt
approved these changes
May 30, 2022
|
Hi @alexmt any plans to also include this on v2.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently health check for HorizontalPodAutoscaler is limited to v1, v2beta1 and v2beta2.
This MR adds support for v2 which is the default HPA API version on Kubernetes 1.23+
Without this MR, ArgoCD will fail to sync any applications that use HPA in Kubernetes 1.23+ clusters.