fix: remove readOnly: false mode for init / wait overlapping volume mounts. Fixes #7755
#8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#7755 As discussed in argoproj#7755, the `init` / `wait` containers surrounding a workflow container mount the same volumes as the `main` container, but without respecting their read/write mode. For environments using PSPs with read-only allowed host paths, it becomes impossible to run workflows that use volume mounts (as sidecar containers will violate the PSP). The original code author (@jessesuen) claims that mounts need to be read/write to allow overlapping mount paths. However, the `main` container will already need to mount paths in read/write mode if they overlap, so there does not seem to be a good reason for keeping this. Fixes argoproj#7755 Signed-off-by: Louis Blin <louis-blin@hotmail.fr>
louisblin
force-pushed
the
fix/sidecar-containers-readonly-psps
branch
from
2599b3f
to
cc9f6a3
Compare
|
I think it needs a test with overlapping volume mount. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Still planning to work on this in the next couple weeks fyi |
|
where @louisblin |
agilgur5
changed the title
readOnly: false mode for init / wait overlapping volume mounts. Fixes #7755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7755, the
init/waitcontainers surrounding a workflow container mount the same volumes as themaincontainer, but without respecting their read/write mode. For environments using PSPs with read-only allowed host paths, it becomes impossible to run workflows that use volume mounts (as sidecar containers will violate the PSP).The original code author (@jessesuen) claims that mounts need to be read/write to allow overlapping mount paths. However, the
maincontainer will already need to mount paths in read/write mode if they overlap, so there does not seem to be a good reason for keeping this.Fixes #7755