Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix changelog script to display the tag creation date #6510

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

steve-marmalade
Copy link
Contributor

Signed-off-by: Steve McClain steve@marmalade.co

Checklist:

This is a very small quality-of-life fix to the hack/changelog.sh script, discussed with @alexec in slack. It now shows the date the tag was created instead of the date of the tagged commit.

@alexec alexec changed the title Fix changelog script to display the tag creation date build: Fix changelog script to display the tag creation date Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #6510 (fdbe2a0) into master (8d60296) will increase coverage by 0.09%.
The diff coverage is 87.87%.

❗ Current head fdbe2a0 differs from pull request most recent head ba96aed. Consider uploading reports for the commit ba96aed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6510      +/-   ##
==========================================
+ Coverage   48.49%   48.58%   +0.09%     
==========================================
  Files         260      260              
  Lines       18804    18827      +23     
==========================================
+ Hits         9119     9148      +29     
+ Misses       8678     8671       -7     
- Partials     1007     1008       +1     
Impacted Files Coverage Δ
util/kubeconfig/kubeconfig.go 31.01% <87.87%> (+11.50%) ⬆️
cmd/argo/commands/get.go 59.18% <0.00%> (+0.29%) ⬆️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d60296...ba96aed. Read the comment docs.

Signed-off-by: Steve McClain <steve@marmalade.co>
@steve-marmalade steve-marmalade force-pushed the fix_changelog_tag_date branch from 66b5036 to ba96aed Compare August 9, 2021 14:02
@alexec alexec merged commit 8b69ec4 into argoproj:master Aug 9, 2021
@sarabala1979 sarabala1979 mentioned this pull request Aug 11, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants