Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): use dl tag instead of p tag in user-info ui #6505

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

shioshiota
Copy link
Contributor

Signed-off-by: Tetsuya Shiota tetsuya.shiota.1231@gmail.com

Checklist:

Tips:

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

<dl> is a more appropriate tag than <p> to display user detail info.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/p

Before:
image

After:
image

Signed-off-by: Tetsuya Shiota <tetsuya.shiota.1231@gmail.com>
@alexec alexec enabled auto-merge (squash) August 9, 2021 20:33
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #6505 (eb75889) into master (a3fd704) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6505      +/-   ##
==========================================
+ Coverage   48.43%   48.51%   +0.07%     
==========================================
  Files         260      260              
  Lines       18804    18804              
==========================================
+ Hits         9108     9122      +14     
+ Misses       8691     8675      -16     
- Partials     1005     1007       +2     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 59.76% <0.00%> (+1.45%) ⬆️
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fd704...eb75889. Read the comment docs.

@alexec alexec merged commit d1d96b0 into argoproj:master Aug 9, 2021
@sarabala1979 sarabala1979 mentioned this pull request Aug 11, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants