-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): Adds PNS_PRIVILEGED, fixed termination bug #4983
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@@ -293,25 +281,6 @@ spec: | |||
}) | |||
} | |||
|
|||
func (s *FunctionalSuite) TestFastFailOnPodTermination() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted as skipped
@@ -554,87 +523,6 @@ func (s *FunctionalSuite) TestParameterAggregation() { | |||
}) | |||
} | |||
|
|||
func (s *FunctionalSuite) TestGlobalScope() { | |||
s.Need(fixtures.BaseLayerArtifacts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted - this test is flakey and it was a time suck fixing it
@@ -1116,38 +1116,29 @@ func (woc *wfOperationCtx) assessNodeStatus(pod *apiv1.Pod, node *wfv1.NodeStatu | |||
} | |||
newDaemonStatus = pointer.BoolPtr(false) | |||
case apiv1.PodRunning: | |||
if pod.DeletionTimestamp != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this condition is incorrect - a pod with a deletion timestamp is one we may have caused to be deleted ourselves - this was incorrect marking nodes as error when they should have been failed
can this be cherry picked for v2.x? |
This is too big to back-port all of it really. Is there a specific thing you need from it? |
will it be easy transition to v3.x? no specific need, just running this using onepanel on microk8s with pns and getting alot of crashes |
Most user should not have any migration issues to v3.0 |
I've removed the need to run ALL tests.
New suites:
I've deleted a few tests (see my comments).
Fixed a bug that marked some workflows as an error when they should have been failed.
Added PNS_PRIVILEGED to run PNS in privileged mode, sometimes needed for GCP.