Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to v3 #4197

Closed
wants to merge 3 commits into from
Closed

feat: Update to v3 #4197

wants to merge 3 commits into from

Conversation

peterbourgon
Copy link

Follow-on from #4183

If your repo has a tag that Go modules parses as semver (like v2.11.1) then the module name in the corresponding go.mod must meet Go modules' expectations, specifically if it is v2 or above it must include a /vN version suffix. If you don't do this, your project is essentially unusable by consumers.

After discussion in #4183 I've bumped the version to v3 and made the necessary changes to import paths. If and when this merges to main, you'll need to tag v3.0.0 for it to all work properly.

Fixes #2602

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexec
Copy link
Contributor

alexec commented Oct 13, 2020

@peterbourgon we may be making some big changes soon and we may well want to fix this problem. Can we close this for the moment, and then I'd like to get you involved in that work?

@alexec alexec self-assigned this Oct 13, 2020
@peterbourgon
Copy link
Author

Happy to advise.

@alexec alexec changed the title go.mod: use version suffix appropriate for tag feat: Update to v3 Oct 17, 2020
@alexec
Copy link
Contributor

alexec commented Oct 17, 2020

@peterbourgon I think we're essentially green-lighted for v3. Do you want to complete this PR to help drive this forward? I can see several build jobs need fixing.

@peterbourgon
Copy link
Author

I don't have enough domain knowledge of the project to make meaningful progress on those. I'm happy to advise whoever can drive the work about modules-related errata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import latest v2.7.0 argo version in go project
3 participants