Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: use version suffix appropriate for tag #4183

Closed
wants to merge 3 commits into from
Closed

go.mod: use version suffix appropriate for tag #4183

wants to merge 3 commits into from

Commits on Oct 1, 2020

  1. go.mod: use version suffix appropriate for tag 

    If your repo has a tag that Go modules parses as semver (like [v2.11.1](https://github.com/argoproj/argo/releases/tag/v2.11.1)) then the module name in the corresponding go.mod must meet Go modules' expectations, specifically if it is v2 or above it must include a `/vN` version suffix. If you don't do this, your project is essentially unusable by consumers.

The fix I've made to go.mod here is simple, but this isn't the end: you also need to update all your import paths to use the `/v2` suffix as well.

Fixes #2602
    @peterbourgon
    peterbourgon authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    ede6901 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Bump to v3 and update import paths

    @peterbourgon
    peterbourgon committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    d9bd98b View commit details
    Browse the repository at this point in the history

  2. Generated files should always be checked in

    @peterbourgon
    peterbourgon committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    2a4bfe1 View commit details
    Browse the repository at this point in the history