fix(ui): Tiny modal DAG tweaks. Fixes #4039 #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
Sep 15, 2020
|
|
||
| private get vgap() { | ||
| return this.nodeSize; | ||
| private get gap() { |
There was a problem hiding this comment.
using a single gap value makes layout more predictable
alexec
commented
Sep 15, 2020
alexec
commented
Sep 15, 2020
| @@ -568,6 +563,12 @@ export class WorkflowDag extends React.Component<WorkflowDagProps, WorkflowDagRe | |||
| } | |||
|
|
|||
| private layoutGraph(nodes: string[], edges: Edge[]) { | |||
| const hash = {scale: this.scale, nodeCount: nodes.length, nodesToDisplay: this.state.nodesToDisplay}; | |||
There was a problem hiding this comment.
move this check here so both graphs benefit
simster7
suggested changes
Sep 15, 2020
Comment on lines
397
to
400
| edgesep: this.gap, | ||
| nodesep: this.gap, | ||
| rankdir: this.state.horizontal ? 'LR' : 'TB', | ||
| ranksep: 50 / this.scale | ||
| ranksep: this.gap |
There was a problem hiding this comment.
Does this change how the graph looks? Could you add a screenshot?
There was a problem hiding this comment.
this makes it more compact - moving from 50px sep to 32px sep (default zoom)
|
Sorry I know this is still in draft mode... jumped the gun on the review |
simster7
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.Fixes #4039
Related to #3595 (#3967)