Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Script Output didn't set if template has RetryStrategy #4002

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

@sarabala1979 sarabala1979 marked this pull request as draft September 11, 2020 06:01
@sarabala1979 sarabala1979 marked this pull request as ready for review September 11, 2020 16:37
@alexec alexec self-assigned this Sep 11, 2020
@alexec
Copy link
Contributor

alexec commented Sep 11, 2020

@sarabala1979 can you sync with master? I don't think we should have the proto differences.

@alexec alexec changed the title fix: Script Output didn't set if template has RetryStrategy fix(controller): Script Output didn't set if template has RetryStrategy Sep 14, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-port to v2.11?

@sarabala1979 sarabala1979 merged commit 4557c71 into argoproj:master Sep 14, 2020
@sarabala1979
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RetryStrategy Not working in the template which has withParams attribute : gives no output to next step
2 participants