Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Changed tagging and amend multi-arch manifest #3854

Merged
merged 1 commit into from
Aug 25, 2020
Merged

ci: Changed tagging and amend multi-arch manifest #3854

merged 1 commit into from
Aug 25, 2020

Conversation

dgiebert
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Hopefully finally closes #2080

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hope!

@dgiebert
Copy link
Contributor Author

Whats the matter with the Semantic Pull Request ? 😓

@dgiebert dgiebert changed the title ci: Change tagging and amend to existing manifest ci: Changed tagging and amend multi-arch manifest Aug 24, 2020
@alexec
Copy link
Contributor

alexec commented Aug 24, 2020

Whats the matter with the Semantic Pull Request ? 😓

If you only have a single commit, then Github uses that, instead of the PR title, as the merge message. You can fix by pushing an empty commit, but don't bother. I'll just edit it when I merge.

@alexec alexec self-assigned this Aug 24, 2020
@alexec alexec merged commit 4e42208 into argoproj:master Aug 25, 2020
@alexec
Copy link
Contributor

alexec commented Aug 25, 2020

Builds now passing on master: did you want to check it?

https://github.com/argoproj/argo/actions/runs/224163851

@dgiebert
Copy link
Contributor Author

dgiebert commented Aug 26, 2020

Did not work as expected:

Let me check why it did only push the windows one.

I will find a solution for it, but the code in docker-ce does not support that yet: https://github.com/docker/docker-ce/blob/19.03/components/cli/cli/command/manifest/create_list.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Workflow for ARM?
2 participants