test: Simplify E2E test tear-down #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
changed the title
alexec
commented
Aug 13, 2020
| serverUnavailable := os.Getenv("ARGO_SERVER") == "" | ||
| if s.Persistence.IsEnabled() && serverUnavailable { | ||
| if !serverUnavailable { | ||
| s.T().Skip("test needs offloading, but the Argo Server is unavailable - if `testNeedsOffloading()` is the first line of your test test, you should move your test to `CliWithServerSuite`?") |
There was a problem hiding this comment.
additional help for people writing tests
alexec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Changes
TestWorkflowLevelSemaphoreandTestTemplateLevelSemaphoreDeleteResourcesto use dynamic informer and wait for resource deletion.CreateConfigMap/DeleteConfigMaptoGiven.