fix: Add flag-protected informer write-back #3745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
commented
Aug 12, 2020
| err = woc.controller.wfInformer.GetStore().Update(un) | ||
| if err != nil { | ||
| woc.log.Errorf("error writing back workflow to informer: %s", err) | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
If the write back fails, simply sleep as we normally would
There was a problem hiding this comment.
I think this is a good idea.
alexec
reviewed
Aug 12, 2020
| @@ -529,7 +530,22 @@ func (woc *wfOperationCtx) persistUpdates() { | |||
| // conflicts arose when attempting to update, causing our conflict resolution code to be invoked. The conflict | |||
| // resolution code was not perfect and workflow information was not correctly persisted, causing undefined behavior. | |||
| // This line was reintroduced in v2.9.5, and should remain as long as we use our current informer pattern. | |||
| time.Sleep(1 * time.Second) | |||
| if os.Getenv("INFORMER_WRITE_BACK") == "true" { | |||
There was a problem hiding this comment.
I think that having this off by default is a good idea. It has cons - we have an untested path of code, which mean it'll rot at some point.
If we can create a test that we can be confident if that we have fixed this, I'd suggest we flip this guard.
|
I wonder if we're approaching this incorrectly. Rather than finding a solution, should we be finding a reliable way to reproduce these kinds of issues? A chaos suite for example? |
6 tasks
|
Closing as we have #4025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3719
I have tested some Workflows known to cause the "conflict" error using the strategy outlined in #3684 (comment) and have so for not seen any issues when using the informer write-back strategy.
My current idea is that we merge this as an opt-in feature-flag protected change. Ask users to test, then consider making it a permanent change if there are no issues.
Things I'd like to consider before moving forward with this: