Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): controller logs to be structured #2308 #3727

Merged
merged 2 commits into from
Aug 11, 2020
Merged

feat(controller): controller logs to be structured #2308 #3727

merged 2 commits into from
Aug 11, 2020

Conversation

sh-tatsuno
Copy link
Contributor

@sh-tatsuno sh-tatsuno commented Aug 11, 2020 •
edited
Loading

rewrite log into a structured form suggested in #2308

Avoid conflicting other branches or taking a lot of steps, I have firstly changed in the controller.

Checklist:

  • this is a chore.
  • suffixes the related issues number
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@sh-tatsuno sh-tatsuno changed the title feat(controller): controller log to be structured #2308 feat(controller): controller logs to be structured #2308 Aug 11, 2020
@sh-tatsuno sh-tatsuno force-pushed the feature/structured-log-controller branch from 4083400 to 386b057 Compare August 11, 2020 02:01
simster7
simster7 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@simster7 simster7 merged commit acfda26 into argoproj:master Aug 11, 2020
@agilgur5 agilgur5 added the area/controller Controller issues, panics label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
area/controller Controller issues, panics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sh-tatsuno @simster7 @agilgur5