Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Adds ALL_POD_CHANGES_SIGNIFICANT #3689

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 6, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec marked this pull request as ready for review August 6, 2020 20:01
@alexec alexec requested a review from simster7 August 6, 2020 20:01
apiv1 "k8s.io/api/core/v1"
)

func SignificantPodChange(from *apiv1.Pod, to *apiv1.Pod) bool {
return from.Spec.NodeName != to.Spec.NodeName ||
return os.Getenv("ALL_POD_CHANGES_SIGNIFICANT") == "true" ||
Copy link
Member

@simster7 simster7 Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag is off by default? Would we want it on by default? Nevermind, I misunderstood the logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually covered by a test, but good to ask

@alexec alexec merged commit a5d995d into argoproj:master Aug 6, 2020
@alexec alexec deleted the sig-log branch August 6, 2020 20:58
@alexec
Copy link
Contributor Author

alexec commented Aug 6, 2020

@alexec
Copy link
Contributor Author

alexec commented Aug 6, 2020

Available in v2.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants