feat: Step and Task Level Global Timeout #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Aug 24, 2020
simster7
suggested changes
Aug 31, 2020
| // Max duration allows for the node execution from node StartTime. | ||
| // This duration includes node pending state also. | ||
| // This duration will not be applied on Step and DAG type Templates | ||
| TimeoutDuration *intstr.IntOrString `json:"timeoutDuration,omitempty" protobuf:"bytes,38,opt,name=timeoutDuration"` |
There was a problem hiding this comment.
Has @jessesuen approved this new API?
simster7
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Minor comments, please make sure @jessesuen approves the API change
Comment on lines
+1704
to
+1706
| if node.Phase == wfv1.NodePending && time.Now().After(deadline) { | ||
| return nil, fmt.Errorf("%s %s exceeded its deadline", node.Name, node.Type) | ||
| } |
There was a problem hiding this comment.
Why is this only when node.Phase == wfv1.NodePending? Shouldn't this check be made regardless of phase?
There was a problem hiding this comment.
This code is mainly handling for nodes that are pending because of waiting for sync lock or parallelism. Rest of state will be handle in createPod function
jessesuen
reviewed
Sep 2, 2020
jessesuen
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Fixes If step is in pending state, step timeout(active deadline seconds) is not working #3572