-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Step and Task Level Global Timeout #3686
Conversation
// Max duration allows for the node execution from node StartTime. | ||
// This duration includes node pending state also. | ||
// This duration will not be applied on Step and DAG type Templates | ||
TimeoutDuration *intstr.IntOrString `json:"timeoutDuration,omitempty" protobuf:"bytes,38,opt,name=timeoutDuration"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has @jessesuen approved this new API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, please make sure @jessesuen approves the API change
if node.Phase == wfv1.NodePending && time.Now().After(deadline) { | ||
return nil, fmt.Errorf("%s %s exceeded its deadline", node.Name, node.Type) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this only when node.Phase == wfv1.NodePending
? Shouldn't this check be made regardless of phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is mainly handling for nodes that are pending because of waiting for sync lock or parallelism. Rest of state will be handle in createPod function
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
. Fixes If step is in pending state, step timeout(active deadline seconds) is not working #3572