Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: interface{} values should be expanded with '%v' #3659

Merged
merged 1 commit into from
Aug 3, 2020
Merged

fix: interface{} values should be expanded with '%v' #3659

merged 1 commit into from
Aug 3, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Aug 3, 2020

Fixes: #3647

@alexec
Copy link
Contributor

alexec commented Aug 3, 2020

I think this might also fix #3653 ?

alexec
alexec approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport?

@simster7 simster7 merged commit 3f293a4 into argoproj:master Aug 3, 2020
@alexec alexec mentioned this pull request Aug 3, 2020
Closed
4 tasks
alexec pushed a commit that referenced this pull request Aug 3, 2020
@simster7 @alexec
fix: interface{} values should be expanded with '%v' (#3659)
2385cca
@alexec
Copy link
Contributor

alexec commented Aug 3, 2020

Fixed and available in v2.10.0-rc5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DAG not stopping when terminated with retry nodes
2 participants
@simster7 @alexec