Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed flaky unit test TestFailSuspendedAndPendingNodesAfterDeadline #3640

Merged
merged 7 commits into from
Jul 30, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Fixes TestFailSuspendedAndPendingNodesAfterDeadline is a flaky test #3637
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sarabala1979 sarabala1979 marked this pull request as draft July 29, 2020 23:08
@sarabala1979 sarabala1979 marked this pull request as ready for review July 30, 2020 15:08
@sarabala1979 sarabala1979 merged commit bcc6e1f into argoproj:master Jul 30, 2020
@alexec
Copy link
Contributor

alexec commented Aug 3, 2020

Fixed and available in v2.10.0-rc5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestFailSuspendedAndPendingNodesAfterDeadline is a flaky test
2 participants