-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Change default language for Resource Editor to YAML and store preference in localStorage. Fixes #3543 #3560
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
eb78237
Change default language in resource editor to YAML. Make note about a…
rbreeze bef9032
Merge branch 'master' into yaml-default
rbreeze 758afef
Make style changes to resource editor and language toggle
rbreeze 04c81a1
Merge branch 'yaml-default' of github.com:rbreeze/argo into yaml-default
rbreeze 98a8367
Merge branch 'master' into yaml-default
rbreeze 9cc69f9
Merge branch 'master' into yaml-default
rbreeze b6fc3fa
Merge branch 'master' into yaml-default
rbreeze 1d8a087
Merge branch 'yaml-default' of github.com:rbreeze/argo into yaml-default
rbreeze b41c090
Linted. Remove some styles. getLang => loadLang
rbreeze 1fce101
Merge branch 'master' into yaml-default
rbreeze 7428766
Inline margin-right
rbreeze ccda3c9
Merge branch 'yaml-default' of github.com:rbreeze/argo into yaml-default
rbreeze 46fad24
fix small mistakes
rbreeze 096c637
lint
rbreeze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 13 additions & 8 deletions
21
ui/src/app/shared/components/resource-editor/resource.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
@import 'node_modules/argo-ui/src/styles/config'; | ||
|
||
.resource { | ||
margin: 10px 0; | ||
padding: 10px 5px; | ||
font: normal 13px/1.2 'Courier New', monospace; | ||
padding-top: 1em; | ||
white-space: pre; | ||
color: $argo-color-gray-7; | ||
border-color: $argo-color-gray-2;; | ||
border-width: thin; | ||
border-style: inset; | ||
overflow-y: scroll; | ||
width: 100%; | ||
min-height: 300px; | ||
} | ||
} | ||
|
||
.resource-editor-panel { | ||
&__editor { | ||
border: 1px solid $argo-color-gray-3; | ||
border-radius: 5px; | ||
margin-top: 1em; | ||
padding-bottom: 1em; | ||
overflow: hidden; | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good guard condition here