-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Make builds marginally faster. Fixes #3515 #3519
Conversation
GIT_TREE_STATE = $(shell if [ -z "`git status --porcelain`" ]; then echo "clean" ; else echo "dirty"; fi) | ||
|
||
export DOCKER_BUILDKIT = 1 | ||
|
||
# To allow you to build with or without cache for debugging purposes. | ||
DOCKER_BUILD_OPTS := --no-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer needed, all builds are done an Github Actions - we should always cache
|
||
.PHONY: publish-release | ||
publish-release: check-version-warning build | ||
# Push images to Docker Hub | ||
docker push $(IMAGE_NAMESPACE)/argocli:$(VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we never push locally for releases
@@ -36,29 +36,6 @@ const Label = "argo-e2e" | |||
// Cron tests run in parallel, so use a different label so they are not deleted when a new test runs | |||
const LabelCron = Label + "-cron" | |||
|
|||
var imageTag string | |||
|
|||
func init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unreliable code removed in v2.9
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.Improvements
There are some slow tests, but no single test which is much worse that other tests. So no improvement to be made there today.
Fixes #3515