fix: Exceeding quota with volumeClaimTemplates #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Jul 16, 2020
alexec
reviewed
Jul 17, 2020
sarabala1979
commented
Jul 20, 2020
sarabala1979
commented
Jul 21, 2020
| @@ -1673,7 +1680,7 @@ func (woc *wfOperationCtx) hasDaemonNodes() bool { | |||
| } | |||
|
|
|||
| func (woc *wfOperationCtx) markWorkflowRunning() { | |||
| woc.markWorkflowPhase(wfv1.NodeRunning, false) | |||
| woc.markWorkflowPhase(wfv1.NodeRunning, false, "") | |||
There was a problem hiding this comment.
Previous error/pending message needs to clear on running phase
sarabala1979
commented
Jul 21, 2020
| @@ -4101,7 +4101,7 @@ status: | |||
| defer cancel() | |||
| woc := newWorkflowOperationCtx(wf, controller) | |||
| woc.operate() | |||
| assert.Equal(t, wfv1.NodePending, woc.wf.Status.Phase) | |||
| assert.Equal(t, wfv1.NodeRunning, woc.wf.Status.Phase) | |||
There was a problem hiding this comment.
Resubmit will memoization wf phase should be running after operate function. I will create separate PR to fix the phase in memorization
There was a problem hiding this comment.
if there is another bug fix - can we combine into a single valid PR?
There was a problem hiding this comment.
sure I will fix the memoization bug also in this PR.
There was a problem hiding this comment.
As per @jessesuen discussed, just need to fix the phase in resubmit memorized scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Fixes Exceeding quota with volumeClaimTemplates #3419