fix: Consider missing optional input/output artifacts with same name #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
changed the title
alexec
reviewed
May 13, 2020
| @@ -0,0 +1,33 @@ | |||
| apiVersion: argoproj.io/v1alpha1 | |||
alexec
reviewed
May 13, 2020
| artifacts: | ||
| - name: file | ||
| path: /tmp/file1.txt | ||
| optional: true |
There was a problem hiding this comment.
I'm not sure optional actually works - can you run without it?
There was a problem hiding this comment.
Running without optional: true fails the validation as expected:
$ argo submit art.yaml
2020/05/13 14:56:52 Failed to submit workflow: templates.plan.steps[0].write templates.file inputs.artifacts.file was not supplied
alexec
approved these changes
May 13, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
|
Review alongside #3019. |
Assuming you meant "make sure that they haven't increased significantly". If so, the test only adds around 8-10 seconds. I think this is good enough.
I took a look and it looks orthogonal. |
simster7
added a commit
that referenced
this pull request
May 27, 2020
|
Back-ported to v2.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750