Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small code cleanup and add tests #1562

Merged
merged 11 commits into from
Sep 21, 2019
Merged

Small code cleanup and add tests #1562

merged 11 commits into from
Sep 21, 2019
+228 −79

Commits on Aug 23, 2019

  1. Factor out the common code for reading manifest files in submit and t… 

    …emplate create
    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    210041d View commit details
    Browse the repository at this point in the history

  2. Handle reading from stdin in a separate case

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    ae7f178 View commit details
    Browse the repository at this point in the history

  3. Add tests for reading from file paths or urls

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    5424f6c View commit details
    Browse the repository at this point in the history

  4. Fix test function description

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    74d7c9d View commit details
    Browse the repository at this point in the history

  5. Fix variable scope

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    738ea4e View commit details
    Browse the repository at this point in the history

  6. Put dry-run before server-dry-run

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    addf17f View commit details
    Browse the repository at this point in the history

  7. Add test for dry-run option of workflow submit command

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    d289d19 View commit details
    Browse the repository at this point in the history

  8. Add a ReadFromStdin function to reduce code duplication

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    d743a62 View commit details
    Browse the repository at this point in the history

  9. Move the read functions to the end of the file

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    f3d987d View commit details
    Browse the repository at this point in the history

  10. Add a ReadManifests function

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    0f1ed3e View commit details
    Browse the repository at this point in the history

  11. Remove second definition of err variable

    @AnesBenmerzoug
    AnesBenmerzoug committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    73aeff7 View commit details
    Browse the repository at this point in the history