Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify qps/burst on controller #14190

Merged
merged 2 commits into from
Feb 13, 2025
Merged

docs: clarify qps/burst on controller #14190

merged 2 commits into from
Feb 13, 2025

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Feb 13, 2025

Modifications

  • Add clarification to how one should use qps and burst on the Controller
  • Conform the docs to our documentation standard

Verification

make docs

Documentation

@tico24
docs: clarify qps/burst on controller
42b7ec3 
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24
more words
37aaaa9 
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 marked this pull request as ready for review February 13, 2025 14:16
@tico24 tico24 marked this pull request as draft February 13, 2025 15:51
@tico24 tico24 marked this pull request as ready for review February 13, 2025 15:51
@Joibel
Copy link
Member

Joibel commented Feb 13, 2025

/cherry-pick release-3.6

@Joibel Joibel merged commit 553c8ad into argoproj:main Feb 13, 2025
17 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 13, 2025
@tico24
docs: clarify qps/burst on controller (#14190)
1b304d8 
Signed-off-by: Tim Collins <tim@thecollins.team>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Feb 13, 2025
Merged
terrytangyuan pushed a commit that referenced this pull request Feb 19, 2025
@gcp-cherry-pick-bot @tico24
docs: clarify qps/burst on controller (cherry-pick #14190) (#14192)
01524a8 
Signed-off-by: Tim Collins <tim@thecollins.team>
Co-authored-by: Tim Collins <45351296+tico24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joibel Joibel Joibel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tico24 @Joibel