Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CODEOWNERS file #12246

Merged
merged 2 commits into from
Nov 23, 2023
Merged

chore: Update CODEOWNERS file #12246

merged 2 commits into from
Nov 23, 2023

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Nov 22, 2023

This has not been updated

Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
@sarabala1979
Copy link
Member

@terrytangyuan Can you help me to understand for this deletion?

@sarabala1979
Copy link
Member

I remember Alex and Jessie added this for Proto change needs to be reviewed by leads. Is the configure broken?

@agilgur5
Copy link
Member

I remember Alex and Jessie added this for Proto change needs to be reviewed by leads. Is the configure broken?

No it works, but as Terry is currently the only one actively approving, it is not particularly useful right now. It can also give a false impression that there are more active approvers than there actually are.
Also, others are getting notifications despite not responding to them -- that may dilute notifications where we may actually want their input more in a direct mention, for instance.

@terrytangyuan
Copy link
Member Author

terrytangyuan commented Nov 23, 2023

A couple of reasons:

  1. Only approvers have permission to merge PRs and all of the ones listed in CODEOWNERS are already approvers.
  2. Neither Alex nor Jesse is lead now. We want to only mention them directly when we want to solicit their input to avoid the noise in their notifications.
  3. I am not sure if it's a good idea to distinguish proto changes from other changes. There are other changes that are important and might be breaking.

@sarabala1979
Copy link
Member

sarabala1979 commented Nov 23, 2023

I am not sure if it's a good idea to distinguish proto changes from other changes. There are other changes that are important and might be breaking.

All CRD changes will be changed in the proto. The main idea is to get two approvers(approver and Leads) for any CRD and API changes. I think it is needed for core files to ensure backward compatibility and the purpose of the change makes sense for the current and future of the project roadmap. This was added because we deprecated/removed a lot of fields previously.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title chore: Delete CODEOWNERS file chore: Update CODEOWNERS file Nov 23, 2023
@terrytangyuan
Copy link
Member Author

@sarabala1979 I changed the PR to update the file instead of deleting it. I removed non-leads from the file.

@sarabala1979 sarabala1979 enabled auto-merge (squash) November 23, 2023 21:43
@sarabala1979 sarabala1979 merged commit 3aa2b81 into master Nov 23, 2023
16 checks passed
@sarabala1979 sarabala1979 deleted the terrytangyuan-patch-1 branch November 23, 2023 21:44
sarabala1979 pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants