-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update CODEOWNERS file #12246
Conversation
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
@terrytangyuan Can you help me to understand for this deletion? |
I remember Alex and Jessie added this for Proto change needs to be reviewed by leads. Is the configure broken? |
No it works, but as Terry is currently the only one actively approving, it is not particularly useful right now. It can also give a false impression that there are more active approvers than there actually are. |
A couple of reasons:
|
All CRD changes will be changed in the proto. The main idea is to get two approvers(approver and Leads) for any CRD and API changes. I think it is needed for core files to ensure backward compatibility and the purpose of the change makes sense for the current and future of the project roadmap. This was added because we deprecated/removed a lot of fields previously. |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@sarabala1979 I changed the PR to update the file instead of deleting it. I removed non-leads from the file. |
This has not been updated