fix(ui): don't use anti-pattern in CheckboxFilter #11739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Per my review, 9cb3783 used an anti-pattern of setting a prop based on another prop - change this to instead set the initial state to have all phases in the top-level component, as I suggested in my comment - CronWorkflowsList now roughly matches how WorkflowsList [sets](https://github.com/argoproj/argo-workflows/blob/8e01696a9c63f25b3660ed479c6f7a57bb61d82d/ui/src/app/workflows/components/workflows-list/workflows-list.tsx#L120) its initial state (it _also_ uses `localStorage` & query params though) - refactor CheckboxFilter to be a functional component - this makes the anti-pattern more obvious (as it would be modifying arguments), as I mentioned in my comment Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Sep 5, 2023
5 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 5, 2023
qudtjs0753
pushed a commit
to qudtjs0753/argo-workflows
that referenced
this pull request
Sep 6, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11686 (comment)
Motivation
Per my review, fix: cron workflow initial filter value. Fixes #11685 #11686 used an anti-pattern of setting a prop based on another prop
CronWorkflowsListnow roughly matches howWorkflowsListsets its initial state (it also useslocalStorage& query params though)refactor
CheckboxFilterto be a functional component8.as wellModifications
ChekboxFilterlogic to instead set the initial state to have all phases in the top-level component,CronWorkflowList, as I suggested in my review commentCheckboxFilterto a functional component as mentioned aboveVerification
/cron-workflowsstateandpropschange as expected./workflowsand confirmed that it works as before and no behavior was changed.See below screenshot of
/cron-workflowswith React DevTools open showing theCheckboxFilterprops:Future Work
This component may be possible to further simplify and optimize:
<React.Fragment>seems unnecessaryI didn't change these as I wanted to keep this PR/diff relatively clean