fix(ui): ensure package.json#name is not the same as argo-ui
#11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- they had the same name before, which logs confusing and could potentially cause very wacky conflicts
- rename to `argo-workflows-ui` to match the current full name of the project (`argo-workflows` fka `argo`)
- also to match Argo CD's [UI name](https://github.com/argoproj/argo-cd/blob/e019b7fecba26d85dcf707dac0f0c76ca2025409/ui/package.json#L2)
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Aug 17, 2023
5 tasks
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…oproj#11595) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Workflows UI and
argo-uihad the same name before, which made logs confusing and could potentially cause very wacky conflictsModifications
rename to
argo-workflows-uito match the current full name of the project (argo-workflowsfkaargo)also alphabetize the
resolutionsresolutionsthe same for consistencyVerification
Install succeeds, build passes. Been working on my local, just split this out as a separate, independent PR