Fix manifests for namespace install

[dtaniwaki]

I wasn't able to use Argo by just installing from the current manifests/namespace-install.yaml because the workflow-controller and argo-ui are installed in default namespace while workflows are expected to run in argo namespace, which the used service account doesn't have access to. I fixed the Role, RoleBinding and the option of argo-ui so it works by just installing the manifests. Please check if this is what you intended.

I didn't update the aggregated manifests which are supposed to be generated by Kustomize because ./hack/update-manifests.sh shows the following error.

$ ./hack/update-manifests.sh
Error: json: unknown field "namespace"
Usage:
  kustomize build [path] [flags]

Examples:
Use the file somedir/kustomization.yaml to generate a set of api resources:
build somedir/

Flags:
  -h, --help   help for build

Global Flags:
      --alsologtostderr                  log to standard error as well as files
      --log_backtrace_at traceLocation   when logging hits line file:N, emit a stack trace (default :0)
      --log_dir string                   If non-empty, write log files in this directory
      --logtostderr                      log to standard error instead of files
      --stderrthreshold severity         logs at or above this threshold go to stderr (default 2)
  -v, --v Level                          log level for V logs
      --vmodule moduleSpec               comma-separated list of pattern=N settings for file-filtered logging

It seems namespace in manifests/cluster-install/kustomization.yaml is not recognized as a valid field. Could you tell me how to update the aggregated manifests, or please do it on your side.

[dtaniwaki]

I updated kustomize to v1.0.10, then ./hack/update-manifests.sh worked successfully.

[dtaniwaki]

I also added the namespace manifest just in case.

[dtaniwaki]

I think I may misunderstand the purpose of each aggregated manifest. Could someone tell me when we use which?

[jessesuen]

@dtaniwaki theres a description of the purpose of the two manifests here:
https://github.com/argoproj/argo/tree/master/manifests

Copied here:
install.yaml - Standard argo cluster-wide installation. Controller operates on all namespaces
namespace-install.yaml - Installation of argo which operates on a single namespace. Controller does not require to be run with clusterrole. Installs to argo namespace as an example.

[jessesuen]

We shouldn't include namespaces as part of install, since namespaces are not often included in installation manifests. Also, oftentimes namespaces are created for other teams, and user's are not allowed a "vanity" namespace.

For example, internally here, we could not use this set of manifests as a kustomize base, since our namespaces are created using a separate namespace provisioning system, using a special convention for the name.

[jessesuen]

I don't think we should split the existing argo-role to two roles: argo-cm-role and argo-role. It makes the object management more confusing.

[dtaniwaki]

I'm closing this PR as the changes are not necessary.