Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow auto-completes to wrong URL #3903

Closed
alexec opened this issue Aug 30, 2020 · 2 comments · Fixed by #3906
Closed

Workflow auto-completes to wrong URL #3903

alexec opened this issue Aug 30, 2020 · 2 comments · Fixed by #3906
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Aug 30, 2020 •
edited
Loading

Summary

Using the autocomplete box on the workflow page sends you to the wrong. Has this ever worked? If not, lets remove it.

autocomplete-bug

Diagnostics

master

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@nirav24
Copy link
Contributor

nirav24 commented Aug 30, 2020

@alexec I think, the problem is, when selecting workflow, it doesn't care about where we are at that time and just append workflow URL (ns/workflowId) to the URL. It can be solved by using an absolute URL when redirecting.

@nirav24 nirav24 mentioned this issue Aug 30, 2020
Merged
6 tasks
alexec pushed a commit that referenced this issue Aug 31, 2020
@nirav24
fix(ui): use absolute URL to redirect from autocomplete list. Closes #…
b681c11 
…3903 (#3906)
@alexec
Copy link
Contributor Author

alexec commented Sep 2, 2020 •
edited
Loading

Available for testing in v2.11.0-rc1.

alexec pushed a commit that referenced this issue Sep 2, 2020
@nirav24 @alexec
fix(ui): use absolute URL to redirect from autocomplete list. Closes #…
ae537cd 
…3903 (#3906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): use absolute URL to redirect from autocomplete list. Closes #3903
2 participants
@alexec @nirav24