fix(plugins): UX improvements (#8122)

* fix(plugins): set Content-Type request header Signed-off-by: Felix Seidel <felix@seidel.me> * fix(plugins): keep namespace from plugin manifest Signed-off-by: Felix Seidel <felix@seidel.me>
argoproj · Mar 10, 2022 · 972a4e9 · 972a4e9
1 parent 019c021
commit 972a4e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/workflow/util/plugins/configmap.go b/workflow/util/plugins/configmap.go
@@ -31,6 +31,7 @@ func ToConfigMap(p *spec.Plugin) (*apiv1.ConfigMap, error) {
 			Labels: map[string]string{
 				common.LabelKeyConfigMapType: p.Kind,
 			},
+			Namespace: p.Namespace,
 		},
 		Data: map[string]string{
 			"sidecar.container": string(data),

diff --git a/workflow/util/plugins/plugin.go b/workflow/util/plugins/plugin.go
@@ -59,6 +59,7 @@ func (p *Client) Call(ctx context.Context, method string, args interface{}, repl
 		if err != nil {
 			return err
 		}
+		req.Header["Content-Type"] = []string{"application/json"}
 		resp, err := p.client.Do(req)
 		if err != nil {
 			return err