Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable UA and GA4 analytics #107

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Enable UA and GA4 analytics #107

merged 1 commit into from
Oct 5, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 27, 2022 •
edited
Loading

/cc @alexmt

In the generated site pages, if you're wondering why send_page_view is false, see gatsbyjs/gatsby#9842 for details.

@chalin chalin force-pushed the chalin-gp-enable-analytics-2022-09-27 branch from c19be2e to 2e745f1 Compare September 27, 2022 17:32
@chalin chalin marked this pull request as draft September 30, 2022 14:08
@chalin
Copy link
Contributor Author

chalin commented Sep 30, 2022 •
edited
Loading

Actually, I'm putting this on hold. I think that for Argo, the better approach will be to use Netlify snippet injection. I forgot that this project uses GitHub pages.

@chalin chalin marked this pull request as ready for review September 30, 2022 14:25
@chalin
Enable analytics
a35e787 
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-gp-enable-analytics-2022-09-27 branch from 2e745f1 to a35e787 Compare October 4, 2022 15:33
alexmt
alexmt approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chalin
Copy link
Contributor Author

chalin commented Oct 5, 2022

Thanks for the review and approval. Anything left to do for this to be merged?

@alexmt alexmt merged commit 6e2ac08 into argoproj:master Oct 5, 2022
@chalin chalin deleted the chalin-gp-enable-analytics-2022-09-27 branch October 5, 2022 20:08
@chalin chalin mentioned this pull request Oct 5, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @alexmt