fix(controller): Fixed broken pprof links #4037 #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekTBrown
changed the title
Signed-off-by: Derek Brown <6845676+DerekTBrown@users.noreply.github.com>
DerekTBrown
force-pushed
the
derektbrown_4037
branch
from
322ccd7 to
e026be3
Compare
|
DerekTBrown
commented
Jan 9, 2025
| mux.HandleFunc(fmt.Sprintf("%s/trace", ProfilingPath), pprof.Trace) | ||
| // TODO: Remove enumerating all pprof endpoints if/when a more ergonomic | ||
| // attachment solution is introduced. See: https://github.com/golang/go/issues/71213. | ||
| mux.HandleFunc("/debug/pprof/", pprof.Index) |
There was a problem hiding this comment.
Note: I believe this is the source of the bug. mux needs the trailing slash to match requests properly:
This was referenced Jan 9, 2025
Closed
Published E2E Test Results 4 files 4 suites 3h 7m 4s ⏱️ Results for commit e026be3. |
Published Unit Test Results2 293 tests 2 293 ✅ 2m 59s ⏱️ Results for commit e026be3. |
zachaller
approved these changes
Jan 10, 2025
zachaller
pushed a commit
that referenced
this pull request
Jan 16, 2025
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".