-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(experiments): move recorder event to after experiment reconciliation, fixes #4021 #4022
Conversation
I have not seen any tests for notifications so I did not add any tests. Locally I've checked that this works and sends the up-to-date Experiment object and not the one with the previous status. |
…oproj#4021 Signed-off-by: Roy Arnon <roy.a@taboola.com>
Published E2E Test Results 4 files 4 suites 3h 8m 23s ⏱️ For more details on these failures, see this check. Results for commit e2be26e. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 293 tests 2 293 ✅ 3m 0s ⏱️ Results for commit e2be26e. ♻️ This comment has been updated with latest results. |
Quality Gate passedIssues Measures |
fixes: #4021
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.