fix: don't over reconcile on error #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Published E2E Test Results 4 files 4 suites 3h 12m 35s ⏱️ For more details on these failures, see this check. Results for commit 62e79f5. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 293 tests 2 293 ✅ 2m 59s ⏱️ Results for commit 62e79f5. ♻️ This comment has been updated with latest results. |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
|
zachaller
added a commit
that referenced
this pull request
Jan 16, 2025
* fix: don't over reconcile on error Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: don't send rollout context on field error Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: cleanup comments Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: cleanup comments Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix typo Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change keeps the logic working the same way as it did in 1.7.x where we did not return any errors on validation issues because we re-queue at 20 seconds instead. There are some interesting logic issues here that have existed for ever that I commented some possible improvement's on but have not done.