Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove condition where header routes can stay directed at empty service in preemption #3898

Merged

lint

5ca1d5e
Select commit
Loading
Failed to load commit list.
Merged

fix: remove condition where header routes can stay directed at empty service in preemption #3898

lint
5ca1d5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 28, 2024 in 0s

82.72% (-1.20%) compared to 806d07c

View this Pull Request on Codecov

82.72% (-1.20%) compared to 806d07c

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (806d07c) to head (5ca1d5e).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
rollout/trafficrouting.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3898      +/-   ##
==========================================
- Coverage   83.92%   82.72%   -1.20%     
==========================================
  Files         163      163              
  Lines       18564    22895    +4331     
==========================================
+ Hits        15579    18939    +3360     
- Misses       2116     3084     +968     
- Partials      869      872       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.