fix(controller): resync replicaset if spec.replicas differs

[chicocvenancio]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[chicocvenancio]

I am unsure if this will fix them, but this is related to at least:

• ProgressDeadlineExceeded: ReplicaSet has timed out progressing #3457
• Rollout stuck issue #3316
• HPA scaling while in scale down delay window causes perpetual "progressing" state on rollout  #3848

[github-actions]

Published E2E Test Results

  4 files    4 suites   3h 14m 37s ⏱️
113 tests 104 ✅  7 💤 2 ❌
456 runs  424 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit f3a804f.

♻️ This comment has been updated with latest results.

[github-actions]

Published Unit Test Results

2 275 tests   2 275 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit f3a804f.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (50300e5) to head (f3a804f).
Report is 80 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3880      +/-   ##
==========================================
- Coverage   83.88%   83.87%   -0.02%     
==========================================
  Files         163      163              
  Lines       18564    18564              
==========================================
- Hits        15573    15571       -2     
- Misses       2119     2120       +1     
- Partials      872      873       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jangeja]

@chicocvenancio any reason why this was closed and not merged in? I'm having the same issue with rollouts currently. Intermittent degraded health for replicasets

[chicocvenancio]

@jangeja I closed it because it doesn't work, this fixes some tests I wrote, but only because unlike k8s api the tests do not properly fill resourceVersion.

f2e1300 is my current hope in getting this properly fixed, we have it running without issue. I still need to clean it up further and write some tests for it.