Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e test results processing change key name to run-id #3744

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

zachaller
Copy link
Collaborator

example had a type of run_id, fix it to the proper run-id

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller changed the title fix: key name to run-id fix: e2e test results processing change key name to run-id Jul 24, 2024
Copy link

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (c727a3c) to head (4b17381).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   78.16%   78.15%   -0.02%     
==========================================
  Files         157      157              
  Lines       22501    22501              
==========================================
- Hits        17588    17585       -3     
- Misses       3999     4002       +3     
  Partials      914      914              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 9884b2a into argoproj:master Jul 24, 2024
24 checks passed
nikoshet pushed a commit to nikoshet/argo-rollouts that referenced this pull request Jul 25, 2024
…3744)

fix key name to run-id

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants