Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move ReplicaSet creation and Rollout validation earlier during the reconciliation process. #3657

Merge branch 'master' of github.com:argoproj/argo-rollouts into fix-r…

8c0e048
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: move ReplicaSet creation and Rollout validation earlier during the reconciliation process. #3657

Merge branch 'master' of github.com:argoproj/argo-rollouts into fix-r…
8c0e048
Select commit
Loading
Failed to load commit list.
GitHub Actions / Published E2E Test Results succeeded Aug 14, 2024 in 0s

6 fail, 7 skipped, 100 pass in 3h 20m 46s

  4 files    4 suites   3h 20m 46s ⏱️
113 tests 100 ✅  7 💤 6 ❌
458 runs  424 ✅ 28 💤 6 ❌

Results for commit 8c0e048.

Annotations

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestCanarySuite/TestCanaryDynamicStableScaleRollbackToStable (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.28)/junit-e2e-test.xml [took 1m 40s]
Raw output
Failed
=== RUN   TestCanarySuite/TestCanaryDynamicStableScaleRollbackToStable
time="2024-08-14T16:23:34Z" level=info msg="Deleting e2e-test-name=TestCanaryDynamicStableScaleRollbackToStable"
time="2024-08-14T16:23:34Z" level=info msg="service/dynamic-stable-scale-root created\n" rollout=dynamic-stable-scale
time="2024-08-14T16:23:34Z" level=info msg="service/dynamic-stable-scale-canary created\n" rollout=dynamic-stable-scale
time="2024-08-14T16:23:34Z" level=info msg="service/dynamic-stable-scale-stable created\n" rollout=dynamic-stable-scale
time="2024-08-14T16:23:34Z" level=info msg="Warning: annotation \"kubernetes.io/ingress.class\" is deprecated, please use 'spec.ingressClassName' instead\ningress.networking.k8s.io/dynamic-stable-scale-ingress created\n" rollout=dynamic-stable-scale
time="2024-08-14T16:23:34Z" level=info msg="rollout.argoproj.io/dynamic-stable-scale created\n" rollout=dynamic-stable-scale
time="2024-08-14T16:23:35Z" level=info msg="Marked 4 revision 1 pods as ready" rollout=dynamic-stable-scale
time="2024-08-14T16:23:35Z" level=info msg="Waiting for condition: status=Healthy" rollout=dynamic-stable-scale
time="2024-08-14T16:23:36Z" level=info msg="Condition 'status=Healthy' met after 0s" rollout=dynamic-stable-scale
time="2024-08-14T16:23:36Z" level=info msg="Updated rollout pod spec: 2024-08-14T16:23:36.906924843Z" rollout=dynamic-stable-scale
time="2024-08-14T16:23:37Z" level=info msg="Marked 1 revision 2 pods as ready" rollout=dynamic-stable-scale
time="2024-08-14T16:23:37Z" level=info msg="Waiting for condition: status=Paused" rollout=dynamic-stable-scale
time="2024-08-14T16:23:38Z" level=info msg="Condition 'status=Paused' met after 0s" rollout=dynamic-stable-scale
time="2024-08-14T16:23:38Z" level=info msg="Sleeping 2s" rollout=dynamic-stable-scale
time="2024-08-14T16:23:40Z" level=info msg="Pod expectation 'revision:1 pod count == 3' met" rollout=dynamic-stable-scale
time="2024-08-14T16:23:40Z" level=info msg="Pod expectation 'revision:2 pod count == 1' met" rollout=dynamic-stable-scale
W0814 16:23:40.895928   26825 warnings.go:70] unknown field "spec.template.metadata.creationTimestamp"
time="2024-08-14T16:23:40Z" level=info msg="Undo rollout to 1" rollout=dynamic-stable-scale
time="2024-08-14T16:23:40Z" level=info msg="Sleeping 2s" rollout=dynamic-stable-scale
time="2024-08-14T16:23:42Z" level=info msg="Pod expectation 'revision:3 pod count == 4' met" rollout=dynamic-stable-scale
time="2024-08-14T16:23:42Z" level=info msg="Pod expectation 'revision:2 pod count == 1' met" rollout=dynamic-stable-scale
time="2024-08-14T16:23:43Z" level=info msg="Marked 1 revision 3 pods as ready" rollout=dynamic-stable-scale
time="2024-08-14T16:23:43Z" level=info msg="Waiting for condition: rev=2 podcount=0" rollout=dynamic-stable-scale
    when.go:467: timeout after 1m30s waiting for condition rev=2 podcount=0
Name:            dynamic-stable-scale
Namespace:       default
Status:          �[32m✔�[0m Healthy
Strategy:        Canary
  Step:          4/4
  SetWeight:     100
  ActualWeight:  100
Images:          nginx:1.19-alpine (�[32mstable�[0m)
Replicas:
  Desired:       4
  Current:       5
  Updated:       4
  Ready:         5
  Available:     5

NAME                                              KIND        STATUS        AGE   INFO
⟳ dynamic-stable-scale                            Rollout     �[32m✔�[0m Healthy     100s  
├──# revision:3                                                                   
│  └──⧉ �[32mdynamic-stable-scale-868d98995b�[0m           ReplicaSet  �[32m✔�[0m Healthy     100s  �[32mstable�[0m
│     ├──□ dynamic-stable-scale-868d98995b-7qm2m  Pod         �[32m✔�[0m Running     100s  ready:1/1
│     ├──□ dynamic-stable-scale-868d98995b-zn8nt  Pod         �[32m✔�[0m Running     100s  ready:1/1
│     ├──□ dynamic-stable-scale-868d98995b-zq4jh  Pod         �[32m✔�[0m Running     100s  ready:1/1
│     └──□ dynamic-stable-scale-868d98995b-mnrqq  Pod         �[32m✔�[0m Running     94s   ready:1/1
└──# revision:2                                                                   
   └──⧉ dynamic-stable-scale-75cf55dd56           ReplicaSet  �[0m•�[0m ScaledDown  98s   

---
apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    rollout.argoproj.io/revision: "3"
  creationTimestamp: "2024-08-14T16:23:34Z"
  generation: 3
  labels:
    argo-rollouts.argoproj.io/controller-instance-id: argo-rollouts-e2e
    e2e-test-name: TestCanaryDynamicStableScaleRollbackToStable
  name: dynamic-stable-scale
  namespace: default
  resourceVersion: "7188"
  uid: 3b31bbd0-a8fe-485e-bdd6-ef6a0c175605
spec:
  replicas: 4
  selector:
    matchLabels:
      app: dynamic-stable-scale
  strategy:
    canary:
      canaryService: dynamic-stable-scale-canary
      dynamicStableScale: true
      stableService: dynamic-stable-scale-stable
      steps:
      - setWeight: 25
      - pause: {}
      - setWeight: 75
      - pause: {}
      trafficRouting:
        alb:
          ingress: dynamic-stable-scale-ingress
          rootService: dynamic-stable-scale-root
          servicePort: 80
  template:
    metadata:
      creationTimestamp: null
      labels:
        app: dynamic-stable-scale
    spec:
      containers:
      - image: nginx:1.19-alpine
        imagePullPolicy: IfNotPresent
        name: dynamic-stable-scale
        ports:
        - containerPort: 80
          name: http
          protocol: TCP
        resources:
          requests:
            cpu: 5m
            memory: 16Mi
        terminationMessagePath: /dev/termination-log
        terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      readinessGates:
      - conditionType: argoproj.io/e2e-readiness
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30
status:
  HPAReplicas: 5
  availableReplicas: 5
  blueGreen: {}
  canary:
    weights:
      canary:
        podTemplateHash: 868d98995b
        serviceName: dynamic-stable-scale-canary
        weight: 0
      stable:
        podTemplateHash: 868d98995b
        serviceName: dynamic-stable-scale-stable
        weight: 100
  conditions:
  - lastTransitionTime: "2024-08-14T16:23:36Z"
    lastUpdateTime: "2024-08-14T16:23:36Z"
    message: Rollout has minimum availability
    reason: AvailableReason
    status: "True"
    type: Available
  - lastTransitionTime: "2024-08-14T16:23:36Z"
    lastUpdateTime: "2024-08-14T16:23:36Z"
    message: Rollout is not healthy
    reason: RolloutHealthy
    status: "False"
    type: Healthy
  - lastTransitionTime: "2024-08-14T16:23:40Z"
    lastUpdateTime: "2024-08-14T16:23:40Z"
    message: RolloutCompleted
    reason: RolloutCompleted
    status: "True"
    type: Completed
  - lastTransitionTime: "2024-08-14T16:23:40Z"
    lastUpdateTime: "2024-08-14T16:23:40Z"
    message: Rollout is paused
    reason: RolloutPaused
    status: "False"
    type: Paused
  - lastTransitionTime: "2024-08-14T16:23:40Z"
    lastUpdateTime: "2024-08-14T16:23:43Z"
    message: ReplicaSet "dynamic-stable-scale-868d98995b" is progressing.
    reason: ReplicaSetUpdated
    status: "True"
    type: Progressing
  currentPodHash: 868d98995b
  currentStepHash: 7c5b668566
  currentStepIndex: 4
  observedGeneration: "3"
  phase: Healthy
  readyReplicas: 5
  replicas: 5
  selector: app=dynamic-stable-scale
  stableRS: 868d98995b
  updatedReplicas: 4

2024-08-14T16:23:34Z         Normal    RolloutAddedToInformer    Rollout resource added to informer: default/dynamic-stable-scale
2024-08-14T16:23:34Z         Normal    RolloutUpdated            Rollout updated to revision 1
2024-08-14T16:23:34Z         Normal    NewReplicaSetCreated      Created ReplicaSet dynamic-stable-scale-868d98995b (revision 1)
2024-08-14T16:23:34Z         Normal    RolloutNotCompleted       Rollout not completed, started update to revision 1 (868d98995b)
2024-08-14T16:23:34Z         Normal    PatchingALBIngress        Updating Ingress `dynamic-stable-scale-ingress` to desiredWeight '0'
2024-08-14T16:23:34Z         Normal    TrafficWeightUpdated      Traffic weight updated to 0
2024-08-14T16:23:34Z         Normal    ScalingReplicaSet         Scaled up ReplicaSet dynamic-stable-scale-868d98995b (revision 1) from 0 to 4
2024-08-14T16:23:34Z         Normal    RolloutCompleted          Rollout completed update to revision 1 (868d98995b): Initial deploy
2024-08-14T16:23:36Z (x2)    Normal    TrafficWeightUpdated      Traffic weight updated 
2024-08-14T16:23:36Z         Normal    SwitchService             Switched selector for service 'dynamic-stable-scale-stable' from '' to '868d98995b'
2024-08-14T16:23:36Z         Normal    SwitchService             Switched selector for service 'dynamic-stable-scale-canary' from '' to '868d98995b'
2024-08-14T16:23:36Z         Normal    RolloutUpdated            Rollout updated to revision 2
2024-08-14T16:23:36Z         Normal    NewReplicaSetCreated      Created ReplicaSet dynamic-stable-scale-75cf55dd56 (revision 2)
2024-08-14T16:23:36Z         Normal    RolloutNotCompleted       Rollout not completed, started update to revision 2 (75cf55dd56)
2024-08-14T16:23:36Z         Normal    ScalingReplicaSet         Scaled up ReplicaSet dynamic-stable-scale-75cf55dd56 (revision 2) from 0 to 1
2024-08-14T16:23:38Z         Normal    SwitchService             Switched selector for service 'dynamic-stable-scale-canary' from '868d98995b' to '75cf55dd56'
2024-08-14T16:23:38Z         Normal    PatchingALBIngress        Updating Ingress `dynamic-stable-scale-ingress` to desiredWeight '25'
2024-08-14T16:23:38Z         Normal    TrafficWeightUpdated      Traffic weight updated from 0 to 25
2024-08-14T16:23:38Z         Normal    RolloutStepCompleted      Rollout step 1/4 completed (setWeight: 25)
2024-08-14T16:23:38Z         Normal    ScalingReplicaSet         Scaled down ReplicaSet dynamic-stable-scale-868d98995b (revision 1) from 4 to 3
2024-08-14T16:23:38Z         Normal    RolloutPaused             Rollout is paused (CanaryPauseStep)
2024-08-14T16:23:40Z         Normal    RolloutUpdated            Rollout updated to revision 3
2024-08-14T16:23:40Z         Normal    SkipSteps                 Rollback to stable ReplicaSets
2024-08-14T16:23:40Z         Normal    RolloutResumed            Rollout is resumed

time="2024-08-14T16:25:14Z" level=info msg="Deleting e2e-test-name=TestCanaryDynamicStableScaleRollbackToStable"
    --- FAIL: TestCanarySuite/TestCanaryDynamicStableScaleRollbackToStable (100.01s)

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestCanarySuite (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.28)/junit-e2e-test.xml [took 6m 21s]
Raw output
Failed
=== RUN   TestCanarySuite
time="2024-08-14T16:23:18Z" level=info msg="analysistemplate.argoproj.io/sleep-job created\n"
--- FAIL: TestCanarySuite (381.63s)

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestAWSSuite/TestALBExperimentStepNoSetWeight (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.27)/junit-e2e-test.xml [took 12s]
Raw output
Failed
=== RUN   TestAWSSuite/TestALBExperimentStepNoSetWeight
time="2024-08-14T16:19:50Z" level=info msg="Deleting e2e-test-name=TestALBExperimentStepNoSetWeight"
time="2024-08-14T16:19:51Z" level=info msg="service/alb-rollout-root created\n" rollout=alb-rollout
time="2024-08-14T16:19:51Z" level=info msg="service/alb-rollout-canary created\n" rollout=alb-rollout
time="2024-08-14T16:19:51Z" level=info msg="service/alb-rollout-stable created\n" rollout=alb-rollout
time="2024-08-14T16:19:51Z" level=info msg="Warning: annotation \"kubernetes.io/ingress.class\" is deprecated, please use 'spec.ingressClassName' instead\ningress.networking.k8s.io/alb-rollout-ingress created\n" rollout=alb-rollout
time="2024-08-14T16:19:51Z" level=info msg="rollout.argoproj.io/alb-rollout created\n" rollout=alb-rollout
time="2024-08-14T16:19:51Z" level=info msg="Waiting for condition: status=Healthy" rollout=alb-rollout
time="2024-08-14T16:19:52Z" level=info msg="Condition 'status=Healthy' met after 1s" rollout=alb-rollout
time="2024-08-14T16:19:52Z" level=info msg="Experiment expectation 'experiment count == 0' met" rollout=alb-rollout
time="2024-08-14T16:19:52Z" level=info msg="Updated rollout pod spec: 2024-08-14T16:19:52.724333159Z" rollout=alb-rollout
time="2024-08-14T16:19:52Z" level=info msg="Sleeping 10s" rollout=alb-rollout
    require.go:72: 
        	Error Trace:	/home/runner/go/pkg/mod/github.com/tj/assert@v0.0.3/require.go:72
        	            				/home/runner/work/argo-rollouts/argo-rollouts/test/e2e/aws_test.go:330
        	            				/home/runner/work/argo-rollouts/argo-rollouts/test/fixtures/then.go:29
        	            				/home/runner/work/argo-rollouts/argo-rollouts/test/e2e/aws_test.go:320
        	Error:      	Not equal: 
        	            	expected: "{\"Type\":\"forward\",\"ForwardConfig\":{\"TargetGroups\":[{\"ServiceName\":\"alb-rollout-canary\",\"ServicePort\":\"80\",\"Weight\":0},{\"ServiceName\":\"\",\"ServicePort\":\"80\",\"Weight\":20},{\"ServiceName\":\"\",\"ServicePort\":\"80\",\"Weight\":20},{\"ServiceName\":\"alb-rollout-stable\",\"ServicePort\":\"80\",\"Weight\":60}]}}"
        	            	actual  : "{\"Type\":\"forward\",\"ForwardConfig\":{\"TargetGroups\":[{\"ServiceName\":\"alb-rollout-canary\",\"ServicePort\":\"80\",\"Weight\":0},{\"ServicePort\":\"80\",\"Weight\":20},{\"ServicePort\":\"80\",\"Weight\":20},{\"ServiceName\":\"alb-rollout-stable\",\"ServicePort\":\"80\",\"Weight\":60}]}}"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-{"Type":"forward","ForwardConfig":{"TargetGroups":[{"ServiceName":"alb-rollout-canary","ServicePort":"80","Weight":0},{"ServiceName":"","ServicePort":"80","Weight":20},{"ServiceName":"","ServicePort":"80","Weight":20},{"ServiceName":"alb-rollout-stable","ServicePort":"80","Weight":60}]}}
        	            	+{"Type":"forward","ForwardConfig":{"TargetGroups":[{"ServiceName":"alb-rollout-canary","ServicePort":"80","Weight":0},{"ServicePort":"80","Weight":20},{"ServicePort":"80","Weight":20},{"ServiceName":"alb-rollout-stable","ServicePort":"80","Weight":60}]}}
        	Test:       	TestAWSSuite/TestALBExperimentStepNoSetWeight
Name:            alb-rollout
Namespace:       default
Status:          �[94m◌�[0m Progressing
Message:         more replicas need to be updated
Strategy:        Canary
  Step:          0/1
  SetWeight:     0
  ActualWeight:  0
Images:          nginx:1.19-alpine (�[32mstable�[0m, �[0mΣ:experiment-alb-canary�[0m, �[0mΣ:experiment-alb-stable�[0m)
Replicas:
  Desired:       1
  Current:       1
  Updated:       0
  Ready:         1
  Available:     1

NAME                                                                 KIND        STATUS         AGE  INFO
⟳ alb-rollout                                                        Rollout     �[94m◌�[0m Progressing  11s  
├──# revision:2                                                                                      
│  ├──⧉ �[33malb-rollout-6fb5cbcb6�[0m                                        ReplicaSet  �[0m•�[0m ScaledDown   10s  �[33mcanary�[0m
│  └──Σ �[94malb-rollout-6fb5cbcb6-2-0�[0m                                    Experiment  �[94m◌�[0m Running      10s  
│     ├──⧉ alb-rollout-6fb5cbcb6-2-0-experiment-alb-canary           ReplicaSet  �[32m✔�[0m Healthy      10s  
│     │  └──□ alb-rollout-6fb5cbcb6-2-0-experiment-alb-canary-nrlsd  Pod         �[32m✔�[0m Running      10s  ready:1/1
│     └──⧉ alb-rollout-6fb5cbcb6-2-0-experiment-alb-stable           ReplicaSet  �[32m✔�[0m Healthy      10s  
│        └──□ alb-rollout-6fb5cbcb6-2-0-experiment-alb-stable-ctxzw  Pod         �[32m✔�[0m Running      10s  ready:1/1
└──# revision:1                                                                                      
   └──⧉ �[32malb-rollout-d6f4fdcdc�[0m                                        ReplicaSet  �[32m✔�[0m Healthy      11s  �[32mstable�[0m
      └──□ alb-rollout-d6f4fdcdc-bnbn9                               Pod         �[32m✔�[0m Running      11s  ready:1/1

---
apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    rollout.argoproj.io/revision: "2"
  creationTimestamp: "2024-08-14T16:19:51Z"
  generation: 4
  labels:
    argo-rollouts.argoproj.io/controller-instance-id: argo-rollouts-e2e
    e2e-test-name: TestALBExperimentStepNoSetWeight
  name: alb-rollout
  namespace: default
  resourceVersion: "4013"
  uid: 031dda38-d40c-4715-b50e-3afb83ae6934
spec:
  replicas: 1
  selector:
    matchLabels:
      app: alb-rollout
  strategy:
    canary:
      canaryService: alb-rollout-canary
      stableService: alb-rollout-stable
      steps:
      - experiment:
          analysisRunMetadata: {}
          duration: 15s
          templates:
          - metadata: {}
            name: experiment-alb-canary
            specRef: canary
            weight: 20
          - metadata: {}
            name: experiment-alb-stable
            specRef: stable
            weight: 20
      trafficRouting:
        alb:
          ingress: alb-rollout-ingress
          rootService: alb-rollout-root
          servicePort: 80
  template:
    metadata:
      annotations:
        update: "2024-08-14T16:19:52.724333159Z"
      creationTimestamp: null
      labels:
        app: alb-rollout
    spec:
      containers:
      - image: nginx:1.19-alpine
        name: alb-rollout
        ports:
        - containerPort: 80
          name: http
          protocol: TCP
        resources:
          requests:
            cpu: 5m
            memory: 16Mi
status:
  HPAReplicas: 1
  availableReplicas: 1
  blueGreen: {}
  canary:
    currentExperiment: alb-rollout-6fb5cbcb6-2-0
    weights:
      additional:
      - weight: 20
      - weight: 20
      canary:
        podTemplateHash: 6fb5cbcb6
        serviceName: alb-rollout-canary
        weight: 0
      stable:
        podTemplateHash: d6f4fdcdc
        serviceName: alb-rollout-stable
        weight: 60
  conditions:
  - lastTransitionTime: "2024-08-14T16:19:52Z"
    lastUpdateTime: "2024-08-14T16:19:52Z"
    message: Rollout has minimum availability
    reason: AvailableReason
    status: "True"
    type: Available
  - lastTransitionTime: "2024-08-14T16:19:52Z"
    lastUpdateTime: "2024-08-14T16:19:52Z"
    message: Rollout is not healthy
    reason: RolloutHealthy
    status: "False"
    type: Healthy
  - lastTransitionTime: "2024-08-14T16:19:51Z"
    lastUpdateTime: "2024-08-14T16:19:52Z"
    message: ReplicaSet "alb-rollout-6fb5cbcb6" is progressing.
    reason: ReplicaSetUpdated
    status: "True"
    type: Progressing
  - lastTransitionTime: "2024-08-14T16:19:52Z"
    lastUpdateTime: "2024-08-14T16:19:52Z"
    message: RolloutCompleted
    reason: RolloutCompleted
    status: "False"
    type: Completed
  currentPodHash: 6fb5cbcb6
  currentStepHash: 8b59978
  currentStepIndex: 0
  message: more replicas need to be updated
  observedGeneration: "4"
  phase: Progressing
  readyReplicas: 1
  replicas: 1
  selector: app=alb-rollout
  stableRS: d6f4fdcdc

2024-08-14T16:19:51Z         Normal    RolloutAddedToInformer    Rollout resource added to informer: default/alb-rollout
2024-08-14T16:19:51Z         Normal    RolloutUpdated            Rollout updated to revision 1
2024-08-14T16:19:51Z         Normal    NewReplicaSetCreated      Created ReplicaSet alb-rollout-d6f4fdcdc (revision 1)
2024-08-14T16:19:51Z         Normal    RolloutNotCompleted       Rollout not completed, started update to revision 1 (d6f4fdcdc)
2024-08-14T16:19:53Z (x2)    Normal    PatchingALBIngress        Updating Ingress `alb-rollout-ingress` to desiredWeight '0'
2024-08-14T16:19:51Z         Normal    TrafficWeightUpdated      Traffic weight updated to 0
2024-08-14T16:19:51Z         Normal    ScalingReplicaSet         Scaled up ReplicaSet alb-rollout-d6f4fdcdc (revision 1) from 0 to 1
2024-08-14T16:19:51Z         Normal    RolloutCompleted          Rollout completed update to revision 1 (d6f4fdcdc): Initial deploy
2024-08-14T16:19:52Z (x2)    Normal    TrafficWeightUpdated      Traffic weight updated 
2024-08-14T16:19:52Z         Normal    SwitchService             Switched selector for service 'alb-rollout-stable' from '' to 'd6f4fdcdc'
2024-08-14T16:19:52Z         Normal    SwitchService             Switched selector for service 'alb-rollout-canary' from '' to 'd6f4fdcdc'
2024-08-14T16:19:52Z         Normal    RolloutUpdated            Rollout updated to revision 2
2024-08-14T16:19:52Z         Normal    NewReplicaSetCreated      Created ReplicaSet alb-rollout-6fb5cbcb6 (revision 2)
2024-08-14T16:19:52Z         Normal    RolloutNotCompleted       Rollout not completed, started update to revision 2 (6fb5cbcb6)
2024-08-14T16:19:52Z         Normal    ExperimentCreated         Created Experiment 'alb-rollout-6fb5cbcb6-2-0'
2024-08-14T16:19:53Z         Normal    TrafficWeightUpdated      Traffic weight updated additional: [{20  } {20  }]

time="2024-08-14T16:20:02Z" level=info msg="Deleting e2e-test-name=TestALBExperimentStepNoSetWeight"
    --- FAIL: TestAWSSuite/TestALBExperimentStepNoSetWeight (12.26s)

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestAWSSuite (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.27)/junit-e2e-test.xml [took 1m 51s]
Raw output
Failed
=== RUN   TestAWSSuite
--- FAIL: TestAWSSuite (111.15s)

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestBlueGreenSuite/TestBlueGreenPreviewReplicaCount (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.26)/junit-e2e-test.xml [took 1m 32s]
Raw output
Failed
=== RUN   TestBlueGreenSuite/TestBlueGreenPreviewReplicaCount
time="2024-08-14T16:21:47Z" level=info msg="Deleting e2e-test-name=TestBlueGreenPreviewReplicaCount"
time="2024-08-14T16:21:47Z" level=info msg="service/bluegreen-preview-replicas-active created\n" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:48Z" level=info msg="service/bluegreen-preview-replicas-preview created\n" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:48Z" level=info msg="rollout.argoproj.io/bluegreen-preview-replicas created\n" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:48Z" level=info msg="Waiting for condition: status=Healthy" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:50Z" level=info msg="Condition 'status=Healthy' met after 2s" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:50Z" level=info msg="Updated rollout pod spec: 2024-08-14T16:21:50.346726122Z" rollout=bluegreen-preview-replicas
time="2024-08-14T16:21:50Z" level=info msg="Waiting for condition: status=Paused" rollout=bluegreen-preview-replicas
    when.go:467: timeout after 1m30s waiting for condition status=Paused
Name:            bluegreen-preview-replicas
Namespace:       default
Status:          �[94m◌�[0m Progressing
Message:         waiting for rollout spec update to be observed
Strategy:        BlueGreen
Images:          nginx:1.19-alpine (�[32mstable�[0m, �[32mactive�[0m)
Replicas:
  Desired:       2
  Current:       2
  Updated:       2
  Ready:         2
  Available:     2

NAME                                                    KIND        STATUS         AGE  INFO
⟳ bluegreen-preview-replicas                            Rollout     �[94m◌�[0m Progressing  92s  
└──# revision:1                                                                         
   └──⧉ �[32m�[32mbluegreen-preview-replicas-66b7c555c5�[0m�[0m           ReplicaSet  �[32m✔�[0m Healthy      92s  �[32mstable�[0m,�[32mactive�[0m
      ├──□ bluegreen-preview-replicas-66b7c555c5-59zgq  Pod         �[32m✔�[0m Running      92s  ready:1/1
      └──□ bluegreen-preview-replicas-66b7c555c5-zcfgl  Pod         �[32m✔�[0m Running      92s  ready:1/1

---
apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    rollout.argoproj.io/revision: "1"
  creationTimestamp: "2024-08-14T16:21:48Z"
  generation: 2
  labels:
    argo-rollouts.argoproj.io/controller-instance-id: argo-rollouts-e2e
    e2e-test-name: TestBlueGreenPreviewReplicaCount
  name: bluegreen-preview-replicas
  namespace: default
  resourceVersion: "5856"
  uid: ba66312c-f94d-43a6-8459-7aad9452a59f
spec:
  replicas: 2
  selector:
    matchLabels:
      app: bluegreen-preview-replicas
  strategy:
    blueGreen:
      activeService: bluegreen-preview-replicas-active
      autoPromotionEnabled: false
      previewReplicaCount: 1
      previewService: bluegreen-preview-replicas-preview
      scaleDownDelaySeconds: 5
  template:
    metadata:
      annotations:
        update: "2024-08-14T16:21:50.346726122Z"
      creationTimestamp: null
      labels:
        app: bluegreen-preview-replicas
    spec:
      containers:
      - image: nginx:1.19-alpine
        name: bluegreen-preview-replicas
        resources:
          requests:
            cpu: 1m
            memory: 16Mi
status:
  HPAReplicas: 2
  availableReplicas: 2
  blueGreen:
    activeSelector: 66b7c555c5
    previewSelector: 66b7c555c5
  canary: {}
  conditions:
  - lastTransitionTime: "2024-08-14T16:21:48Z"
    lastUpdateTime: "2024-08-14T16:21:48Z"
    message: RolloutCompleted
    reason: RolloutCompleted
    status: "True"
    type: Completed
  - lastTransitionTime: "2024-08-14T16:21:50Z"
    lastUpdateTime: "2024-08-14T16:21:50Z"
    message: Rollout is healthy
    reason: RolloutHealthy
    status: "True"
    type: Healthy
  - lastTransitionTime: "2024-08-14T16:21:48Z"
    lastUpdateTime: "2024-08-14T16:21:50Z"
    message: ReplicaSet "bluegreen-preview-replicas-66b7c555c5" has successfully progressed.
    reason: NewReplicaSetAvailable
    status: "True"
    type: Progressing
  - lastTransitionTime: "2024-08-14T16:21:50Z"
    lastUpdateTime: "2024-08-14T16:21:50Z"
    message: Rollout has minimum availability
    reason: AvailableReason
    status: "True"
    type: Available
  currentPodHash: 66b7c555c5
  observedGeneration: "1"
  phase: Healthy
  readyReplicas: 2
  replicas: 2
  selector: app=bluegreen-preview-replicas,rollouts-pod-template-hash=66b7c555c5
  stableRS: 66b7c555c5
  updatedReplicas: 2

2024-08-14T16:21:48Z    Normal    RolloutAddedToInformer    Rollout resource added to informer: default/bluegreen-preview-replicas
2024-08-14T16:21:48Z    Normal    RolloutUpdated            Rollout updated to revision 1
2024-08-14T16:21:48Z    Normal    NewReplicaSetCreated      Created ReplicaSet bluegreen-preview-replicas-66b7c555c5 (revision 1)
2024-08-14T16:21:48Z    Normal    SwitchService             Switched selector for service 'bluegreen-preview-replicas-preview' from '' to '66b7c555c5'
2024-08-14T16:21:48Z    Normal    ScalingReplicaSet         Scaled up ReplicaSet bluegreen-preview-replicas-66b7c555c5 (revision 1) from 0 to 2
2024-08-14T16:21:48Z    Normal    RolloutCompleted          Rollout completed update to revision 1 (66b7c555c5): Initial deploy
2024-08-14T16:21:50Z    Normal    SwitchService             Switched selector for service 'bluegreen-preview-replicas-active' from '' to '66b7c555c5'

time="2024-08-14T16:23:20Z" level=info msg="Deleting e2e-test-name=TestBlueGreenPreviewReplicaCount"
    --- FAIL: TestBlueGreenSuite/TestBlueGreenPreviewReplicaCount (92.84s)

Check warning on line 0 in github.com/argoproj/argo-rollouts/test/e2e

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

1 out of 5 runs failed: TestBlueGreenSuite (github.com/argoproj/argo-rollouts/test/e2e)

artifacts/E2E Test Results (k8s 1.26)/junit-e2e-test.xml [took 3m 44s]
Raw output
Failed
=== RUN   TestBlueGreenSuite
--- FAIL: TestBlueGreenSuite (224.02s)

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

7 skipped tests found

There are 7 skipped tests, see "Raw output" for the full list of skipped tests.
Raw output
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBBlueGreenUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBCanaryUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBCanaryUpdateMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAppMeshSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestSMIIngressSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestSMISuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestStepPluginSuite

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Published E2E Test Results

113 tests found

There are 113 tests, see "Raw output" for the full list of tests.
Raw output
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAPISIXSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAPISIXSuite/TestAPISIXCanarySetHeaderStep
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAPISIXSuite/TestAPISIXCanaryStep
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBBlueGreenUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBCanaryUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBCanaryUpdateMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBExperimentStep
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBExperimentStepMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBExperimentStepNoSetWeight
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBExperimentStepNoSetWeightMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBMesh_PingPong_StableCanary_Update
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBPingPongUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestALBPingPongUpdateMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestAlbHeaderRoute
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAWSSuite/TestAlbHeaderRouteMultiIngress
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestAnalysisWithArgs
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestAnalysisWithSecret
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBackgroundAnalysisWithArgs
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBlueGreenAbortAndUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBlueGreenAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBlueGreenKitchenSink
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBlueGreenPostPromotionFail
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestBlueGreenPrePromotionFail
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestCanaryBackgroundAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestCanaryFailInlineMultipleAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestCanaryInlineAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestCanaryInlineMultipleAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAnalysisSuite/TestMultipleAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestAppMeshSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestBlueGreenSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestBlueGreenSuite/TestBlueGreenPreviewReplicaCount
github.com/argoproj/argo-rollouts/test/e2e ‑ TestBlueGreenSuite/TestBlueGreenProgressDeadlineExceededWithPause
github.com/argoproj/argo-rollouts/test/e2e ‑ TestBlueGreenSuite/TestBlueGreenProgressDeadlineExceededWithoutPause
github.com/argoproj/argo-rollouts/test/e2e ‑ TestBlueGreenSuite/TestEphemeralMetadata
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryDynamicStableScale
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryDynamicStableScaleRollbackToStable
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryProgressDeadlineExceededWithPause
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryScaleDownDelay
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryScaleDownDelayWithProgressDeadline
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryScaleDownOnAbort
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryScaleDownOnAbortNoTrafficRouting
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanarySetCanaryScale
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryUnScaleDownOnAbort
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestCanaryWithPausedRollout
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestEphemeralMetadata
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestReduceWeightAndHonorMaxUnavailable
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestRolloutScalingDuringUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestRolloutScalingWhenPaused
github.com/argoproj/argo-rollouts/test/e2e ‑ TestCanarySuite/TestRolloutWithMaxSurgeScalingDuringUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestExperimentWithDryRunMetrics
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestExperimentWithMeasurementRetentionMetrics
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestExperimentWithMultiportServiceAndScaleDownDelay
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestExperimentWithServiceAndScaleDownDelay
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestExperimentWithServiceNameAndScaleDownDelay
github.com/argoproj/argo-rollouts/test/e2e ‑ TestExperimentSuite/TestRolloutWithExperimentAndAnalysis
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenExceedProgressDeadlineAbort
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenPreviewReplicaCountPromoteFull
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenPromoteFull
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenScaleDownDelay
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenScaleDownOnAbort
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenToCanary
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestBlueGreenUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestCanaryPromoteFull
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestCompleteRolloutRestart
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestContainerResourceFormats
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestControllerMetrics
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestFixInvalidSpec
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestKubectlWaitForCompleted
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestKubectlWaitForPaused
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestMalformedRollout
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestMalformedRolloutEphemeralCtr
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestNeverScaleDown
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutAbortRetryPromote
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutBadToBadUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutBadToGoodSetWeightUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutBadToGoodUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutGoodToBadUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutPDBRestart
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutPauseDurationGreaterThanProgressDeadlineSeconds
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutPodVolumesItemsSpec
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestRolloutRestart
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestScaleDownOnSuccess
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestScaleDownProgressively
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestSpecAndReplicaChangeSameTime
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestWorkloadRef
github.com/argoproj/argo-rollouts/test/e2e ‑ TestFunctionalSuite/TestWorkloadRefTemplate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestHeaderRoutingSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestHeaderRoutingSuite/TestIstioHostHeaderRoute
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioAbortUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioAbortUpdateDeleteAllCanaryPods
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioHostSplit
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioHostSplitExperimentStep
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioHostSplitOnlyTls
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioPingPongUpdate
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioSubsetSplit
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioSubsetSplitExperimentStep
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioSubsetSplitInStableDownscaleAfterCanaryAbort
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioSubsetSplitSingleRoute
github.com/argoproj/argo-rollouts/test/e2e ‑ TestIstioSuite/TestIstioUpdateInMiddleZeroCanaryReplicas
github.com/argoproj/argo-rollouts/test/e2e ‑ TestMirrorRouteSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestMirrorRouteSuite/TestIstioHostMirrorRoute
github.com/argoproj/argo-rollouts/test/e2e ‑ TestRollbackSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestRollbackSuite/TestRollbackAnalysisOutsideWindow
github.com/argoproj/argo-rollouts/test/e2e ‑ TestRollbackSuite/TestRollbackAnalysisWithinWindow
github.com/argoproj/argo-rollouts/test/e2e ‑ TestSMIIngressSuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestSMISuite
github.com/argoproj/argo-rollouts/test/e2e ‑ TestStepPluginSuite