fix: PR Fixes

Signed-off-by: Matthew Clarke <mclarke@spotify.com>
argoproj · Jul 9, 2024 · 98df9ed · 98df9ed
1 parent d3804cc
commit 98df9ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/metricproviders/prometheus/prometheus.go b/metricproviders/prometheus/prometheus.go
@@ -136,17 +136,17 @@ func (p *Provider) GarbageCollect(run *v1alpha1.AnalysisRun, metric v1alpha1.Met
 	return nil
 }
 
-func sampleValuesToFloatSlice(SampleValues []model.SampleValue) []float64 {
-	results := make([]float64, 0, len(SampleValues))
-	for _, s := range SampleValues {
+func sampleValuesToFloatSlice(sampleValues []model.SampleValue) []float64 {
+	results := make([]float64, 0, len(sampleValues))
+	for _, s := range sampleValues {
 		results = append(results, float64(s))
 	}
 	return results
 }
 
-func sampleValuesToResultStr(SampleValues []model.SampleValue) string {
+func sampleValuesToResultStr(sampleValues []model.SampleValue) string {
 	results := []string{}
-	for _, s := range SampleValues {
+	for _, s := range sampleValues {
 		results = append(results, s.String())
 	}
 	return fmt.Sprintf("[%s]", strings.Join(results, ","))

diff --git a/utils/evaluate/evaluate.go b/utils/evaluate/evaluate.go
@@ -61,10 +61,8 @@ func EvalTime(expression string) (time.Time, error) {
 	var err error
 
 	env := map[string]any{
-		"asInt":   asInt,
-		"asFloat": asFloat,
-		"isNaN":   math.IsNaN,
-		"isInf":   isInf,
+		"isNaN": math.IsNaN,
+		"isInf": isInf,
 	}
 
 	unwrapFileErr := func(e error) error {
@@ -88,7 +86,7 @@ func EvalTime(expression string) (time.Time, error) {
 	case time.Time:
 		return val, nil
 	default:
-		return time.Time{}, fmt.Errorf("expected string, but got %T", val)
+		return time.Time{}, fmt.Errorf("expected time.Time, but got %T", val)
 	}
 }