Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo): Allow Argo server read access to events. #454

Merged
merged 3 commits into from
Sep 22, 2020
Merged

feat(argo): Allow Argo server read access to events. #454

merged 3 commits into from
Sep 22, 2020

Conversation

vladlosev
Copy link
Collaborator

This change gives Argo server the permission to read events, to the event display feature in 2.11.

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

@vladlosev vladlosev changed the title Fix give argo server permission on events feat(argo): Allow Argo server read access to events. Sep 22, 2020
stefansedich
stefansedich approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@stefansedich stefansedich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefansedich stefansedich merged commit e3371f3 into argoproj:master Sep 22, 2020
@vladlosev vladlosev deleted the fix-give-argo-server-permission-on-events branch September 22, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansedich stefansedich stefansedich approved these changes

@benjaminws benjaminws Awaiting requested review from benjaminws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladlosev @stefansedich