Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Add an extra feature toggle to the argocd configmap that allows sync impersonation #3138

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat(argo-cd): Add an extra feature toggle to the argocd configmap that allows sync impersonation #3138

merged 5 commits into from
Jan 27, 2025

Conversation

Nheijmink19
Copy link
Contributor

@Nheijmink19 Nheijmink19 commented Jan 24, 2025 •
edited by mbevc1
Loading

…impersonation

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@Nheijmink19
Add an extra feature toggle to the argocd configmap that allows sync …
7cb42bb 
…impersonation

Signed-off-by: Nick Heijmink <nick.heijmink@alliander.com>
@tico24 tico24 marked this pull request as draft January 24, 2025 14:13
@Nheijmink19 Nheijmink19 changed the title Add an extra feature toggle to the argocd configmap that allows sync … feat(argo-cd): Add an extra feature toggle to the argocd configmap that allows sync … Jan 24, 2025
@Nheijmink19 Nheijmink19 marked this pull request as ready for review January 24, 2025 14:23
@Nheijmink19
Copy link
Contributor Author

This is an update to the argo-cd helm chart only. Using this change we allow the use of the sync impersonation functionality of ArgoCD.

@Nheijmink19 Nheijmink19 marked this pull request as draft January 24, 2025 15:18
@Nheijmink19
update documentation
bbbdf6f 
Signed-off-by: Nick Heijmink <nick.heijmink@alliander.com>
@Nheijmink19 Nheijmink19 marked this pull request as ready for review January 24, 2025 15:22
@yu-croco yu-croco changed the title feat(argo-cd): Add an extra feature toggle to the argocd configmap that allows sync … feat(argo-cd): Add an extra feature toggle to the argocd configmap that allows sync impersonation Jan 25, 2025
Nheijmink19 and others added 3 commits January 27, 2025 10:38
@Nheijmink19 @yu-croco
Add alpha label to comment of sa sync impersonation
5314625 
Co-authored-by: Aikawa <yu.croco@gmail.com>
Signed-off-by: Nick Heijmink <75807895+Nheijmink19@users.noreply.github.com>
@Nheijmink19
Merge branch 'main' into argo-cd-helm-cm-add-feature-toggle-impersona…
6088a42 
…tion
@Nheijmink19
Fix the docs
c9c440b 
Signed-off-by: Nick Heijmink <nick.heijmink@alliander.com>
@Nheijmink19 Nheijmink19 force-pushed the argo-cd-helm-cm-add-feature-toggle-impersonation branch from 8475802 to c9c440b Compare January 27, 2025 09:47
yu-croco
yu-croco approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkilchhofer mkilchhofer merged commit c2f3d99 into argoproj:main Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 mbevc1 approved these changes

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nheijmink19 @mkilchhofer @mbevc1 @yu-croco