Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update some dependencies and add some comments about old libs (#22104) #22208

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Mar 6, 2025

Closes #22104

A final PR for this ticket, update some versions of old libs and leave some comments about their state to help with next steps.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner March 6, 2025 02:27
Copy link

bunnyshell bot commented Mar 6, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (29c69b3) to head (c57b4c3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22208      +/-   ##
==========================================
- Coverage   55.80%   55.80%   -0.01%     
==========================================
  Files         342      342              
  Lines       57206    57212       +6     
==========================================
+ Hits        31924    31925       +1     
- Misses      22649    22652       +3     
- Partials     2633     2635       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of the version bumps, but the comments are a bit verbose. Can we move them out to an issue?

@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22104-update-dependencies-for-argo-cd branch from c57b4c3 to 6c0fe9a Compare March 6, 2025 15:07
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22104-update-dependencies-for-argo-cd branch from eb3cdbf to d22d9c0 Compare March 6, 2025 16:51
…rgoproj#22104)

Closes argoproj#22104

A final PR for this ticket, update some versions of old libs and leave some comments about their state to help with next steps.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22104-update-dependencies-for-argo-cd branch from d22d9c0 to 651cf77 Compare March 6, 2025 19:30
@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev, @rumstead CI has finally passed. For this one there's been frequent merge conflicts due to other deps update. Can you merge when you have time, so other merge conflicts don't appear, please?

@crenshaw-dev crenshaw-dev merged commit 8d1aeb5 into argoproj:master Mar 6, 2025
27 checks passed
kahou82 pushed a commit to kahou82/argo-cd that referenced this pull request Mar 9, 2025
…rgoproj#22104) (argoproj#22208)

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Kahou Lei <kahou82@gmail.com>
pedro-cs-ribeiro pushed a commit to pedro-cs-ribeiro/argo-cd that referenced this pull request Mar 10, 2025
…rgoproj#22104) (argoproj#22208)

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Pedro Ribeiro <pedro.ribeiro@cross-join.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update some dependencies
3 participants