-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update some dependencies and add some comments about old libs (#22104) #22208
chore: Update some dependencies and add some comments about old libs (#22104) #22208
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22208 +/- ##
==========================================
- Coverage 55.80% 55.80% -0.01%
==========================================
Files 342 342
Lines 57206 57212 +6
==========================================
+ Hits 31924 31925 +1
- Misses 22649 22652 +3
- Partials 2633 2635 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of the version bumps, but the comments are a bit verbose. Can we move them out to an issue?
c57b4c3
to
6c0fe9a
Compare
eb3cdbf
to
d22d9c0
Compare
…rgoproj#22104) Closes argoproj#22104 A final PR for this ticket, update some versions of old libs and leave some comments about their state to help with next steps. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
d22d9c0
to
651cf77
Compare
@crenshaw-dev, @rumstead CI has finally passed. For this one there's been frequent merge conflicts due to other deps update. Can you merge when you have time, so other merge conflicts don't appear, please? |
…rgoproj#22104) (argoproj#22208) Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Kahou Lei <kahou82@gmail.com>
…rgoproj#22104) (argoproj#22208) Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com> Signed-off-by: Pedro Ribeiro <pedro.ribeiro@cross-join.com>
Closes #22104
A final PR for this ticket, update some versions of old libs and leave some comments about their state to help with next steps.
Checklist: