fix(hydrator): don't get cluster or API versions for hydrator #21985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21985 +/- ##
==========================================
+ Coverage 55.73% 56.68% +0.95%
==========================================
Files 342 342
Lines 57080 57823 +743
==========================================
+ Hits 31811 32775 +964
+ Misses 22633 22421 -212
+ Partials 2636 2627 -9 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
force-pushed
the
fix-hydrator-cluster-access
branch
from
700b6ca to
4aba937
Compare
|
I added a test, but the test was more tech debt than it was worth (a bunch of mocks, etc.). The GetRepoObjs function needs to be refactored. For now, I've tested the fix in an Intuit instance and confirmed with @agaudreault. |
agaudreault
approved these changes
Feb 25, 2025
rumstead
approved these changes
Feb 25, 2025
|
/cherry-pick release-2.14 |
|
Cherry-pick failed with |
crenshaw-dev
added a commit
to crenshaw-dev/argo-cd
that referenced
this pull request
Feb 26, 2025
…oj#21985) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picking to 2.14 here: #22038 |
crenshaw-dev
added a commit
that referenced
this pull request
Feb 26, 2025
#22038) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
skyscannerBajpai
pushed a commit
to skyscannerBajpai/argo-cd
that referenced
this pull request
Feb 27, 2025
…oj#21985) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Harshit-Bajpai <Harshit.Bajpai@skyscanner.net>
chzar
pushed a commit
to chzar/argo-cd
that referenced
this pull request
Mar 3, 2025
…oj#21985) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Mar 4, 2025
…oj#21985) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: kingbj0429 <kingbj0429@lunit.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hydrator doesn't use the k8s server or API versions, so we shouldn't try to get them.
This fixes a bug where hydration on one shard might not have access to a cluster for an app that's destined for a cluster being handled by another shard.
Fixes #21986