Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) (cherry-pick #21298) #21952

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: correctly set compareWith when requesting app refresh with delay (fixes #18998) (#21298)

  • fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen s@sxn.dev

  • test: add UT

Signed-off-by: Xiaonan Shen s@sxn.dev


Signed-off-by: Xiaonan Shen s@sxn.dev
Co-authored-by: 沈啸楠 sxn@shenxiaonandeMacBook-Pro.local

…fixes #18998) (#21298)

* fix: correctly set compareWith when requesting app refresh with delay

Signed-off-by: Xiaonan Shen <s@sxn.dev>

* test: add UT

Signed-off-by: Xiaonan Shen <s@sxn.dev>

---------

Signed-off-by: Xiaonan Shen <s@sxn.dev>
Co-authored-by: 沈啸楠 <sxn@shenxiaonandeMacBook-Pro.local>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner February 23, 2025 17:20
@gdsoumya gdsoumya merged commit 92a3c3d into release-2.14 Feb 23, 2025
11 of 13 checks passed
@gdsoumya gdsoumya deleted the cherry-pick-7c0719-release-2.14 branch February 23, 2025 17:21
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.19%. Comparing base (aaed35c) to head (7b5a1fe).
Report is 1 commits behind head on release-2.14.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.14   #21952      +/-   ##
================================================
- Coverage         55.15%   53.19%   -1.97%     
================================================
  Files               338      338              
  Lines             57182    57182              
================================================
- Hits              31538    30417    -1121     
- Misses            22937    24109    +1172     
+ Partials           2707     2656      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants